[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC v1 2/3] util/qemu-error: Add a warning_report() fu
From: |
Daniel P. Berrange |
Subject: |
Re: [Qemu-devel] [RFC v1 2/3] util/qemu-error: Add a warning_report() function |
Date: |
Wed, 28 Jun 2017 10:04:48 +0100 |
User-agent: |
Mutt/1.8.0 (2017-02-23) |
On Tue, Jun 27, 2017 at 01:45:45PM -0700, Alistair Francis wrote:
> Add a functino which can be used similarly to error_report() execpt to
> inform the users about warnings instead of errors.
>
> The warning print does not include the timestamp and instead will
> preface the messages with a 'warning: '.
Not including the timestamp is a bug IMHO. If I've turned on timestamps,
I expect all messages to have the timestamp.
I'm not particularly convinced by adding the 'warning: ' prefix either,
particularly given the scenario you are using this in, is not actually
a warning - its just a informative message.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
[Qemu-devel] [RFC v1 3/3] char-socket: Report TCP socket waiting as a warning, Alistair Francis, 2017/06/27
Re: [Qemu-devel] [RFC v1 0/3] Implement a warning_report function, Daniel P. Berrange, 2017/06/28