[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 0/4] xen: don't save/restore the physmap on V
From: |
no-reply |
Subject: |
Re: [Qemu-devel] [PATCH v3 0/4] xen: don't save/restore the physmap on VM save/restore |
Date: |
Tue, 11 Jul 2017 07:06:44 -0700 (PDT) |
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: address@hidden
Type: series
Subject: [Qemu-devel] [PATCH v3 0/4] xen: don't save/restore the physmap on VM
save/restore
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
893068b xen: don't use xenstore to save/restore physmap anymore
bab7b78 xen/mapcache: introduce xen_replace_cache_entry()
b1ed857 xen/mapcache: add an ability to create dummy mappings
f0688e9 xen: move physmap saving into a separate function
=== OUTPUT BEGIN ===
Checking PATCH 1/4: xen: move physmap saving into a separate function...
Checking PATCH 2/4: xen/mapcache: add an ability to create dummy mappings...
Checking PATCH 3/4: xen/mapcache: introduce xen_replace_cache_entry()...
ERROR: space required before the open parenthesis '('
#180: FILE: hw/i386/xen/xen-mapcache.c:541:
+ if(!test_bits(address_offset >> XC_PAGE_SHIFT,
total: 1 errors, 0 warnings, 205 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 4/4: xen: don't use xenstore to save/restore physmap anymore...
ERROR: space prohibited between function name and open parenthesis '('
#48: FILE: hw/i386/xen/xen-hvm.c:380:
+ physmap = g_malloc(sizeof (XenPhysmap));
total: 1 errors, 0 warnings, 120 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden
- [Qemu-devel] [PATCH v3 0/4] xen: don't save/restore the physmap on VM save/restore, Igor Druzhinin, 2017/07/10
- [Qemu-devel] [PATCH v3 1/4] xen: move physmap saving into a separate function, Igor Druzhinin, 2017/07/10
- [Qemu-devel] [PATCH v3 2/4] xen/mapcache: add an ability to create dummy mappings, Igor Druzhinin, 2017/07/10
- [Qemu-devel] [PATCH v3 3/4] xen/mapcache: introduce xen_replace_cache_entry(), Igor Druzhinin, 2017/07/10
- [Qemu-devel] [PATCH v3 4/4] xen: don't use xenstore to save/restore physmap anymore, Igor Druzhinin, 2017/07/10
- Re: [Qemu-devel] [PATCH v3 0/4] xen: don't save/restore the physmap on VM save/restore, no-reply, 2017/07/11
- Re: [Qemu-devel] [PATCH v3 0/4] xen: don't save/restore the physmap on VM save/restore,
no-reply <=
- Re: [Qemu-devel] [PATCH v3 0/4] xen: don't save/restore the physmap on VM save/restore, no-reply, 2017/07/11