[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v12 07/27] target/i386: [tcg] Port to insn_start
From: |
Alex Bennée |
Subject: |
Re: [Qemu-devel] [PATCH v12 07/27] target/i386: [tcg] Port to insn_start |
Date: |
Wed, 12 Jul 2017 10:21:21 +0100 |
User-agent: |
mu4e 0.9.19; emacs 25.2.50.3 |
Lluís Vilanova <address@hidden> writes:
> Incrementally paves the way towards using the generic instruction translation
> loop.
>
> Signed-off-by: Lluís Vilanova <address@hidden>
> Reviewed-by: Emilio G. Cota <address@hidden>
> Reviewed-by: Richard Henderson <address@hidden>
Reviewed-by: Alex Bennée <address@hidden>
> ---
> target/i386/translate.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/target/i386/translate.c b/target/i386/translate.c
> index 7819545e37..a4b9e5628f 100644
> --- a/target/i386/translate.c
> +++ b/target/i386/translate.c
> @@ -8448,6 +8448,13 @@ static void
> i386_tr_init_disas_context(DisasContextBase *dcbase, CPUState *cpu)
> cpu_cc_srcT = tcg_temp_local_new();
> }
>
> +static void i386_tr_insn_start(DisasContextBase *dcbase, CPUState *cpu)
> +{
> + DisasContext *dc = container_of(dcbase, DisasContext, base);
> +
> + tcg_gen_insn_start(dc->base.pc_next, dc->cc_op);
> +}
> +
> /* generate intermediate code for basic block 'tb'. */
> void gen_intermediate_code(CPUState *cs, TranslationBlock *tb)
> {
> @@ -8475,7 +8482,7 @@ void gen_intermediate_code(CPUState *cs,
> TranslationBlock *tb)
>
> gen_tb_start(tb);
> for(;;) {
> - tcg_gen_insn_start(dc->base.pc_next, dc->cc_op);
> + i386_tr_insn_start(&dc->base, cs);
> num_insns++;
>
> /* If RF is set, suppress an internally generated breakpoint. */
--
Alex Bennée
- Re: [Qemu-devel] [PATCH v12 04/27] target: [tcg] Add generic translation framework, (continued)
Re: [Qemu-devel] [PATCH v12 04/27] target: [tcg] Add generic translation framework, Alex Bennée, 2017/07/11
[Qemu-devel] [PATCH v12 05/27] target/i386: [tcg] Port to DisasContextBase, Lluís Vilanova, 2017/07/07
[Qemu-devel] [PATCH v12 06/27] target/i386: [tcg] Port to init_disas_context, Lluís Vilanova, 2017/07/07
[Qemu-devel] [PATCH v12 07/27] target/i386: [tcg] Port to insn_start, Lluís Vilanova, 2017/07/07
- Re: [Qemu-devel] [PATCH v12 07/27] target/i386: [tcg] Port to insn_start,
Alex Bennée <=
[Qemu-devel] [PATCH v12 08/27] target/i386: [tcg] Port to breakpoint_check, Lluís Vilanova, 2017/07/07
[Qemu-devel] [PATCH v12 09/27] target/i386: [tcg] Port to translate_insn, Lluís Vilanova, 2017/07/07
[Qemu-devel] [PATCH v12 10/27] target/i386: [tcg] Port to tb_stop, Lluís Vilanova, 2017/07/07
[Qemu-devel] [PATCH v12 11/27] target/i386: [tcg] Port to disas_log, Lluís Vilanova, 2017/07/07
[Qemu-devel] [PATCH v12 12/27] target/i386: [tcg] Port to generic translation framework, Lluís Vilanova, 2017/07/07
[Qemu-devel] [PATCH v12 13/27] target/arm: [tcg] Port to DisasContextBase, Lluís Vilanova, 2017/07/07
[Qemu-devel] [PATCH v12 14/27] target/arm: [tcg] Port to init_disas_context, Lluís Vilanova, 2017/07/07
[Qemu-devel] [PATCH v12 15/27] target/arm: [tcg, a64] Port to init_disas_context, Lluís Vilanova, 2017/07/07