qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH for-2.11 1/5] qmp-shell: Use argparse module


From: Daniel P. Berrange
Subject: Re: [Qemu-devel] [PATCH for-2.11 1/5] qmp-shell: Use argparse module
Date: Tue, 8 Aug 2017 11:11:06 +0100
User-agent: Mutt/1.8.3 (2017-05-23)

On Tue, Aug 08, 2017 at 11:07:21AM +0100, Stefan Hajnoczi wrote:
> On Fri, Aug 04, 2017 at 06:36:21PM -0300, Eduardo Habkost wrote:
> > It makes command-line parsing and generation of help text much
> > simpler.
> > 
> > Signed-off-by: Eduardo Habkost <address@hidden>
> > ---
> >  scripts/qmp/qmp-shell | 61 
> > +++++++++++++++++----------------------------------
> >  1 file changed, 20 insertions(+), 41 deletions(-)
> 
> The minimum Python version is 2.6.  The argparse module was introduced
> in Python 2.7 so we cannot use it without increasing the minimum Python
> version:
> 
> https://docs.python.org/2.6/modindex.html
> 
> I suggest holding off on this for now.

Although its deprecated, perhaps we can use  optparse instead ? It is
available in py2 & 3 and very similar to argparse.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|



reply via email to

[Prev in Thread] Current Thread [Next in Thread]