[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v7 10/11] qemu.py: don't launch again before shutdow
From: |
Amador Pahim |
Subject: |
[Qemu-devel] [PATCH v7 10/11] qemu.py: don't launch again before shutdown() |
Date: |
Fri, 18 Aug 2017 19:05:25 +0200 |
If a VM is launched, files are created and a cleanup is required before
a new launch. This cleanup is executed by shutdown(), so shutdown() must
be called even if the VM is manually terminated (i.e. using kill).
This patch creates a control to make sure launch() will not be executed
again if shutdown() is not called after the previous launch().
Signed-off-by: Amador Pahim <address@hidden>
---
scripts/qemu.py | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/scripts/qemu.py b/scripts/qemu.py
index 46e8ff3232..2bd81afcf2 100644
--- a/scripts/qemu.py
+++ b/scripts/qemu.py
@@ -52,6 +52,7 @@ class QEMUMachine(object):
self._debug = debug
self._qemu_full_args = None
self._created_files = []
+ self._pending_shutdown = False
# This can be used to add an unused monitor instance.
def add_monitor_telnet(self, ip, port):
@@ -173,6 +174,9 @@ class QEMUMachine(object):
if self.is_running():
raise QEMULaunchError('VM already running')
+ if self._pending_shutdown:
+ raise QEMULaunchError('Shutdown pending after previous launch')
+
try:
self._pre_launch()
self._qemu_full_args = (self._wrapper + [self._binary] +
@@ -183,6 +187,7 @@ class QEMUMachine(object):
stderr=subprocess.STDOUT,
shell=False)
self._post_launch()
+ self._pending_shutdown = True
except:
self.shutdown()
@@ -215,6 +220,7 @@ class QEMUMachine(object):
self._load_io_log()
self._post_shutdown()
+ self._pending_shutdown = False
underscore_to_dash = string.maketrans('_', '-')
def qmp(self, cmd, conv_keys=True, **args):
--
2.13.5
[Qemu-devel] [PATCH v7 05/11] qemu.py: cleanup redundant calls in launch(), Amador Pahim, 2017/08/18
[Qemu-devel] [PATCH v7 04/11] qemu.py: use poll() instead of 'returncode', Amador Pahim, 2017/08/18
[Qemu-devel] [PATCH v7 11/11] qemu.py: refactor launch(), Amador Pahim, 2017/08/18