[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v7 07/11] qemu.py: include debug information on
From: |
Cleber Rosa |
Subject: |
Re: [Qemu-devel] [PATCH v7 07/11] qemu.py: include debug information on launch error |
Date: |
Wed, 30 Aug 2017 11:55:05 -0400 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 |
On 08/18/2017 01:05 PM, Amador Pahim wrote:
> When launching a VM, if an exception happens and the VM is not
> initiated, it might be useful to see the qemu command line and
> the qemu command output.
>
> This patch creates that message. Notice that self._iolog needs to be
> cleaned up in the beginning of the launch() to make sure we will not
> expose the qemu log from a previous launch if the current one fails.
>
> Signed-off-by: Amador Pahim <address@hidden>
> ---
> scripts/qemu.py | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/scripts/qemu.py b/scripts/qemu.py
> index 0bcec4b3b1..29fd2469f9 100644
> --- a/scripts/qemu.py
> +++ b/scripts/qemu.py
> @@ -147,6 +147,7 @@ class QEMUMachine(object):
>
> def launch(self):
> '''Launch the VM and establish a QMP connection'''
> + self._iolog = None
> self._qemu_full_args = None
> devnull = open(os.path.devnull, 'rb')
> qemulog = open(self._qemu_log_path, 'wb')
> @@ -162,6 +163,13 @@ class QEMUMachine(object):
> self._post_launch()
> except:
> self.shutdown()
> +
> + LOG.debug('Error launching VM')
> + if self._qemu_full_args:
> + LOG.debug('Command: %r', ' '.join(self._qemu_full_args))
> + if self._iolog:
> + LOG.debug('Output: %r', self._iolog)
> +
Based on Fam's comment about the signal message being a warning (worth
showing by default), I also think this deserves more than a "debug"
classification.
- Cleber.
> raise
>
> def shutdown(self):
>
signature.asc
Description: OpenPGP digital signature
[Qemu-devel] [PATCH v7 05/11] qemu.py: cleanup redundant calls in launch(), Amador Pahim, 2017/08/18