[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 for-2.11 08/18] target/s390x: move gtod_*() d
From: |
Cornelia Huck |
Subject: |
Re: [Qemu-devel] [PATCH v3 for-2.11 08/18] target/s390x: move gtod_*() declarations to s390-virtio.h |
Date: |
Mon, 21 Aug 2017 13:14:30 +0200 |
On Mon, 21 Aug 2017 13:05:12 +0200
David Hildenbrand <address@hidden> wrote:
> On 21.08.2017 12:08, Cornelia Huck wrote:
> > In s390-virtio.c, the only thing used outside of s390-virtio-ccw.c is
> > s390_cpuaddr2state(), and the only place that uses it for something
> > other than getting a dummy cpu is the kvm sigp target code. Can we
> > replace that last usage with a different construct?
>
> As CPUs are stored in s390-virtio.c (S390CPU **cpu_states) this is not
> possible. We could only get access to cpu #x via qom /machine/cpu[#x],
> but I guess that won't have best performance :)
>
> We could move that definition into the machine state (which would make
> sense, as the cpus belong to a machine).
The machine state looks like a better place than s390-virtio.c.
>
> >
> > In s390-virtio.h, the s390_register_virtio_hypercall() interface is the
> > only thing that still makes sense to be exported.
> >
>
> Anyhow, I would prefer to have these cleanups in a separate series.
> Nevertheless they make perfect sense.
This is certainly material for a different series :) Just thought I'd
write down what I noticed.
- [Qemu-devel] [PATCH v3 for-2.11 07/18] s390x: drop inclusion of sysemu/kvm.h from some files, (continued)
[Qemu-devel] [PATCH v3 for-2.11 08/18] target/s390x: move gtod_*() declarations to s390-virtio.h, David Hildenbrand, 2017/08/18
[Qemu-devel] [PATCH v3 for-2.11 09/18] target/s390x: move cc_name() to helper.c, David Hildenbrand, 2017/08/18
[Qemu-devel] [PATCH v3 for-2.11 10/18] target/s390x: move cpu_mmu_idx_to_asc() to excp_helper.c, David Hildenbrand, 2017/08/18
[Qemu-devel] [PATCH v3 for-2.11 12/18] target/s390x: move s390_do_cpu_reset() to diag.c, David Hildenbrand, 2017/08/18
[Qemu-devel] [PATCH v3 for-2.11 11/18] target/s390x: move psw_key_valid() to mem_helper.c, David Hildenbrand, 2017/08/18
[Qemu-devel] [PATCH v3 for-2.11 13/18] target/s390x: move get_per_in_range() to misc_helper.c, David Hildenbrand, 2017/08/18
[Qemu-devel] [PATCH v3 for-2.11 14/18] target/s390x: introduce internal.h, David Hildenbrand, 2017/08/18
[Qemu-devel] [PATCH v3 for-2.11 16/18] s390x: avoid calling kvm_ functions outside of target/s390x/, David Hildenbrand, 2017/08/18
[Qemu-devel] [PATCH v3 for-2.11 15/18] target/s390x: move a couple of functions to cpu.c, David Hildenbrand, 2017/08/18
[Qemu-devel] [PATCH v3 for-2.11 17/18] s390x/kvm: move KVM declarations and stubs to separate files, David Hildenbrand, 2017/08/18
[Qemu-devel] [PATCH v3 for-2.11 18/18] target/s390x: cleanup cpu.h, David Hildenbrand, 2017/08/18