[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 05/10] s390x/pci: do not advertise pci on non
From: |
Thomas Huth |
Subject: |
Re: [Qemu-devel] [PATCH v4 05/10] s390x/pci: do not advertise pci on non-pci builds |
Date: |
Mon, 21 Aug 2017 14:29:28 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 |
On 21.08.2017 11:16, Cornelia Huck wrote:
> Only set the zpci feature bit on builds that actually support pci.
>
> Reviewed-by: David Hildenbrand <address@hidden>
> Signed-off-by: Cornelia Huck <address@hidden>
> ---
> target/s390x/kvm.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/target/s390x/kvm.c b/target/s390x/kvm.c
> index c4c5791d27..bc62bba5b7 100644
> --- a/target/s390x/kvm.c
> +++ b/target/s390x/kvm.c
> @@ -2662,7 +2662,9 @@ void kvm_s390_get_host_cpu_model(S390CPUModel *model,
> Error **errp)
> }
>
> /* We emulate a zPCI bus and AEN, therefore we don't need HW support */
> - set_bit(S390_FEAT_ZPCI, model->features);
> + if (pci_available) {
> + set_bit(S390_FEAT_ZPCI, model->features);
> + }
> set_bit(S390_FEAT_ADAPTER_EVENT_NOTIFICATION, model->features);
>
> if (s390_known_cpu_type(cpu_type)) {
>
Reviewed-by: Thomas Huth <address@hidden>
- [Qemu-devel] [PATCH v4 00/10] zpci detangling, Cornelia Huck, 2017/08/21
- [Qemu-devel] [PATCH v4 04/10] s390x: chsc nt2 events are pci-only, Cornelia Huck, 2017/08/21
- [Qemu-devel] [PATCH v4 03/10] s390x/pci: add stubs, Cornelia Huck, 2017/08/21
- [Qemu-devel] [PATCH v4 05/10] s390x/pci: do not advertise pci on non-pci builds, Cornelia Huck, 2017/08/21
- Re: [Qemu-devel] [PATCH v4 05/10] s390x/pci: do not advertise pci on non-pci builds,
Thomas Huth <=
- [Qemu-devel] [PATCH v4 06/10] s390x/ccw: create s390 phb conditionally, Cornelia Huck, 2017/08/21
- [Qemu-devel] [PATCH v4 08/10] s390x/pci: fence off instructions for non-pci, Cornelia Huck, 2017/08/21
- [Qemu-devel] [PATCH v4 07/10] s390x/sclp: properly guard pci-specific functions, Cornelia Huck, 2017/08/21
- Re: [Qemu-devel] [PATCH v4 07/10] s390x/sclp: properly guard pci-specific functions, Pierre Morel, 2017/08/21