[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 07/10] s390x/sclp: properly guard pci-specifi
From: |
Cornelia Huck |
Subject: |
Re: [Qemu-devel] [PATCH v4 07/10] s390x/sclp: properly guard pci-specific functions |
Date: |
Mon, 21 Aug 2017 15:36:12 +0200 |
On Mon, 21 Aug 2017 15:32:23 +0200
Halil Pasic <address@hidden> wrote:
> On 08/21/2017 03:16 PM, Cornelia Huck wrote:
> > On Mon, 21 Aug 2017 13:41:53 +0200
> > Halil Pasic <address@hidden> wrote:
> >
> >> On 08/21/2017 11:16 AM, Cornelia Huck wrote:
> >>> If we do not provide zpci, pci reconfiguration via sclp is not available
> >>> either. Don't indicate it in the sclp facilities and return an invalid
> >>> command if the guest tries to issue pci configure/deconfigure.
> >>>
> >>> Reviewed-by: Thomas Huth <address@hidden>
> >>> Signed-off-by: Cornelia Huck <address@hidden>
> >>> ---
> >>> hw/s390x/sclp.c | 19 +++++++++++++++----
> >>> 1 file changed, 15 insertions(+), 4 deletions(-)
> >
> > (...)
> >
> >> LGTM
> >
> > Is that an Acked-by:? Or a Reviewed-by:? :)
> >
>
> r-b
If you write that out in future, I can simply copy'n'paste it :)
>
> (Not sure what Acked-by from a role other that affected
> maintainer means.)
I've always used it in the sense of "I don't know the gory details, and
I haven't tried to find them out, but it generally looks sane to me".
- Re: [Qemu-devel] [PATCH v4 04/10] s390x: chsc nt2 events are pci-only, (continued)
- [Qemu-devel] [PATCH v4 03/10] s390x/pci: add stubs, Cornelia Huck, 2017/08/21
- [Qemu-devel] [PATCH v4 05/10] s390x/pci: do not advertise pci on non-pci builds, Cornelia Huck, 2017/08/21
- [Qemu-devel] [PATCH v4 06/10] s390x/ccw: create s390 phb conditionally, Cornelia Huck, 2017/08/21
- [Qemu-devel] [PATCH v4 08/10] s390x/pci: fence off instructions for non-pci, Cornelia Huck, 2017/08/21
- [Qemu-devel] [PATCH v4 07/10] s390x/sclp: properly guard pci-specific functions, Cornelia Huck, 2017/08/21
- Re: [Qemu-devel] [PATCH v4 07/10] s390x/sclp: properly guard pci-specific functions, Pierre Morel, 2017/08/21
- Re: [Qemu-devel] [PATCH v4 07/10] s390x/sclp: properly guard pci-specific functions, Halil Pasic, 2017/08/21
- Re: [Qemu-devel] [PATCH v4 07/10] s390x/sclp: properly guard pci-specific functions, Cornelia Huck, 2017/08/22
- Re: [Qemu-devel] [PATCH v4 07/10] s390x/sclp: properly guard pci-specific functions, Halil Pasic, 2017/08/22
- Re: [Qemu-devel] [PATCH v4 07/10] s390x/sclp: properly guard pci-specific functions, Cornelia Huck, 2017/08/22
- Re: [Qemu-devel] [PATCH v4 07/10] s390x/sclp: properly guard pci-specific functions, Cornelia Huck, 2017/08/22
- Re: [Qemu-devel] [PATCH v4 07/10] s390x/sclp: properly guard pci-specific functions, Halil Pasic, 2017/08/22
- Re: [Qemu-devel] [PATCH v4 07/10] s390x/sclp: properly guard pci-specific functions, Halil Pasic, 2017/08/22
- Re: [Qemu-devel] [PATCH v4 07/10] s390x/sclp: properly guard pci-specific functions, Cornelia Huck, 2017/08/22
- Re: [Qemu-devel] [PATCH v4 07/10] s390x/sclp: properly guard pci-specific functions, Halil Pasic, 2017/08/22