[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] build-sys: generate tests/.gitignore
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH] build-sys: generate tests/.gitignore |
Date: |
Tue, 5 Sep 2017 15:43:51 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 09/04/2017 04:03 AM, Marc-André Lureau wrote:
> tests/.gitignore is often out of date. Let's generate it based on the
> files and directories to clean.
In fact, it got out-of-date again with the recent cbb6540.
>
> Note: I didn't succeed yet at generalizing this approach for the rest
> of qemu .gitignore files, but I hope it may eventually happen.
>
> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
> Makefile | 7 +++-
> tests/.gitignore | 97
> ----------------------------------------------
> tests/Makefile.include | 39 +++++++++++++++++--
> tests/migration/.gitignore | 2 -
> 4 files changed, 41 insertions(+), 104 deletions(-)
> delete mode 100644 tests/.gitignore
> delete mode 100644 tests/migration/.gitignore
>
> @@ -14,6 +14,11 @@ ifneq ($(wildcard config-host.mak),)
> all:
> include config-host.mak
>
> +.PHONY: gitignore
> +ifneq ($(filter-out $(UNCHECKED_GOALS),$(MAKECMDGOALS)),$(if
> $(MAKECMDGOALS),,fail))
> +all $(MAKECMDGOALS): gitignore
> +endif
As others have mentioned, can we make this conditional on being an
in-tree build, so that a VPATH build isn't modifying non-local files
(after all, .gitignore only matters for an in-tree build)?
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature