[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] build-sys: generate tests/.gitignore
From: |
Thomas Huth |
Subject: |
Re: [Qemu-devel] [PATCH] build-sys: generate tests/.gitignore |
Date: |
Wed, 6 Sep 2017 07:05:17 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 05.09.2017 12:42, Marc-André Lureau wrote:
> Hi
>
> On Mon, Sep 4, 2017 at 12:21 PM Thomas Huth <address@hidden
> <mailto:address@hidden>> wrote:
>
> On 04.09.2017 11 <tel:04%2009%2020%2017%2011>:03, Marc-André Lureau
> wrote:
[...]
> > # Build the help program automatically
> >
> > all: $(QEMU_IOTESTS_HELPERS-y)
> >
> > +$(SRC_PATH)/tests/.gitignore: $(MAKEFILE_LIST)
> > + $(call quiet-command, echo "$(tests-cleanfiles)"
> "$(tests-cleandirs)" | \
> > + xargs -n1 | sort | uniq | sed -e s:^:/: >
> $@,"GEN","$(@F)")
>
> Please do not use SRC_PATH here. I'm doing out of tree builds, and I
> don't want that these are touching my source folder!
>
> I understand the feeling, I do also mostly out of tree build. However, I
> don't think it makes much sense to generate .gitignore in the build dir.
Why not? If you're doing out-of-tree builds, you don't need the
.gitignore in the source directory anyway, so it certainly does not make
sense to generate there such a file in the source directory.
> It's git related, and in the git source dir, you have .git that is
> writable already
It's unlikely, but I think it is perfectly legal to have your git source
directory e.g. mounted temporarily as a read-only file system. I'd then
still expect to be able to use my read-only sources to build QEMU out of
tree.
Thomas
PS: Looks like you're sending HTML mails ... please check the setup of
your mail program.