[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] buildsys: Move rdma libs to per object
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-devel] [PATCH] buildsys: Move rdma libs to per object |
Date: |
Thu, 7 Sep 2017 10:37:32 +0100 |
User-agent: |
Mutt/1.8.3 (2017-05-23) |
* Fam Zheng (address@hidden) wrote:
> Signed-off-by: Fam Zheng <address@hidden>
OK, I've not actually got a preference as to whether it's
per-object or not - I don't really see any advantage.
But since it doesn't look like it'll break it;
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
> ---
> configure | 2 +-
> migration/Makefile.objs | 1 +
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index fb7e34a901..470b8a085b 100755
> --- a/configure
> +++ b/configure
> @@ -2818,7 +2818,6 @@ EOF
> rdma_libs="-lrdmacm -libverbs"
> if compile_prog "" "$rdma_libs" ; then
> rdma="yes"
> - libs_softmmu="$libs_softmmu $rdma_libs"
> else
> if test "$rdma" = "yes" ; then
> error_exit \
> @@ -6035,6 +6034,7 @@ echo "CONFIG_TRACE_FILE=$trace_file" >> $config_host_mak
>
> if test "$rdma" = "yes" ; then
> echo "CONFIG_RDMA=y" >> $config_host_mak
> + echo "RDMA_LIBS=$rdma_libs" >> $config_host_mak
> fi
>
> if test "$have_rtnetlink" = "yes" ; then
> diff --git a/migration/Makefile.objs b/migration/Makefile.objs
> index 1c7770da46..99e038024d 100644
> --- a/migration/Makefile.objs
> +++ b/migration/Makefile.objs
> @@ -11,3 +11,4 @@ common-obj-$(CONFIG_RDMA) += rdma.o
>
> common-obj-$(CONFIG_LIVE_BLOCK_MIGRATION) += block.o
>
> +rdma.o-libs := $(RDMA_LIBS)
> --
> 2.13.5
>
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK