Re: [Qemu-devel] [PATCH] buildsys: Move rdma libs to per object

[Fam Zheng]

On Thu, 09/07 10:37, Dr. David Alan Gilbert wrote:
> * Fam Zheng (address@hidden) wrote:
> > Signed-off-by: Fam Zheng <address@hidden>
> 
> OK, I've not actually got a preference as to whether it's
> per-object or not - I don't really see any advantage.

Thanks for the review.  You're right this probably doesn't make a difference
except for a bit more consistency, until we want to make rdma a module (as in
--enable-modules) like the ones in block layer. The -libs and -cflags variables
were initially added just for that.

While we are talking about it, is there any reason why that will not be a good
idea?  There are other libraries used by QEMU outside block layer that are
overdue to be converted to modules, like ui (gtk, sdl, etc.), rdma seems to be a
candidate too.

Fam