[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v10 4/6] hmp: create a throttle initialization f
From: |
Greg Kurz |
Subject: |
Re: [Qemu-devel] [PATCH v10 4/6] hmp: create a throttle initialization function for code reusability |
Date: |
Fri, 8 Sep 2017 14:31:04 +0200 |
On Mon, 4 Sep 2017 12:07:45 -0400
Pradeep Jagadeesh <address@hidden> wrote:
> This patch creates a throttle initialization function to maximize the
> code reusability. The same code is also used by fsdev.
>
s/is also/will also be/
> Acked-by: Dr. David Alan Gilbert <address@hidden>
> Signed-off-by: Pradeep Jagadeesh <address@hidden>
> ---
Reviewed-by: Greg Kurz <address@hidden>
> hmp.c | 19 +++++++++++++------
> 1 file changed, 13 insertions(+), 6 deletions(-)
>
> diff --git a/hmp.c b/hmp.c
> index fd80dce..2dbfb80 100644
> --- a/hmp.c
> +++ b/hmp.c
> @@ -1758,20 +1758,27 @@ void hmp_change(Monitor *mon, const QDict *qdict)
> hmp_handle_error(mon, &err);
> }
>
> +static void hmp_initialize_io_throttle(IOThrottle *iot, const QDict *qdict)
> +{
> + iot->bps = qdict_get_int(qdict, "bps");
> + iot->bps_rd = qdict_get_int(qdict, "bps_rd");
> + iot->bps_wr = qdict_get_int(qdict, "bps_wr");
> + iot->iops = qdict_get_int(qdict, "iops");
> + iot->iops_rd = qdict_get_int(qdict, "iops_rd");
> + iot->iops_wr = qdict_get_int(qdict, "iops_wr");
> +}
> +
> void hmp_block_set_io_throttle(Monitor *mon, const QDict *qdict)
> {
> Error *err = NULL;
> + IOThrottle *iothrottle;
> BlockIOThrottle throttle = {
> .has_device = true,
> .device = (char *) qdict_get_str(qdict, "device"),
> - .bps = qdict_get_int(qdict, "bps"),
> - .bps_rd = qdict_get_int(qdict, "bps_rd"),
> - .bps_wr = qdict_get_int(qdict, "bps_wr"),
> - .iops = qdict_get_int(qdict, "iops"),
> - .iops_rd = qdict_get_int(qdict, "iops_rd"),
> - .iops_wr = qdict_get_int(qdict, "iops_wr"),
> };
>
> + iothrottle = qapi_BlockIOThrottle_base(&throttle);
> + hmp_initialize_io_throttle(iothrottle, qdict);
> qmp_block_set_io_throttle(&throttle, &err);
> hmp_handle_error(mon, &err);
> }
pgp1E6ef84f2k.pgp
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH v10 6/6] fsdev: hmp interface for throttling, (continued)
Re: [Qemu-devel] [PATCH v10 6/6] fsdev: hmp interface for throttling, Dr. David Alan Gilbert, 2017/09/05
[Qemu-devel] [PATCH v10 5/6] fsdev: QMP interface for throttling, Pradeep Jagadeesh, 2017/09/04
[Qemu-devel] [PATCH v10 4/6] hmp: create a throttle initialization function for code reusability, Pradeep Jagadeesh, 2017/09/04
Re: [Qemu-devel] [PATCH v10 0/6] fsdev: qmp interface for io throttling, Eric Blake, 2017/09/05