[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 12/19] nvic: In escalation to HardFault, support
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH 12/19] nvic: In escalation to HardFault, support HF not being priority -1 |
Date: |
Tue, 19 Sep 2017 13:50:26 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 09/12/2017 01:13 PM, Peter Maydell wrote:
> When escalating to HardFault, we must go into Lockup if we
> can't take the synchronous HardFault because the current
> execution priority is already at or below the priority of
> HardFault. In v7M HF is always priority -1 so a simple < 0
> comparison sufficed; in v8M the priority of HardFault can
> vary depending on whether it is a Secure or NonSecure
> HardFault, so we must check against the priority of the
> HardFault exception vector we're about to use.
>
> Signed-off-by: Peter Maydell <address@hidden>
> ---
> hw/intc/armv7m_nvic.c | 23 ++++++++++++-----------
> 1 file changed, 12 insertions(+), 11 deletions(-)
Reviewed-by: Richard Henderson <address@hidden>
r~
- Re: [Qemu-devel] [PATCH 15/19] nvic: Handle v8M changes in nvic_exec_prio(), (continued)
- [Qemu-devel] [PATCH 17/19] nvic: Make ICSR banked for v8M, Peter Maydell, 2017/09/12
- [Qemu-devel] [PATCH 09/19] nvic: Make set_pending and clear_pending take a secure parameter, Peter Maydell, 2017/09/12
- [Qemu-devel] [PATCH 01/19] target/arm: Implement MSR/MRS access to NS banked registers, Peter Maydell, 2017/09/12
- [Qemu-devel] [PATCH 07/19] nvic: Implement NVIC_ITNS<n> registers, Peter Maydell, 2017/09/12
- [Qemu-devel] [PATCH 12/19] nvic: In escalation to HardFault, support HF not being priority -1, Peter Maydell, 2017/09/12
- Re: [Qemu-devel] [PATCH 12/19] nvic: In escalation to HardFault, support HF not being priority -1,
Richard Henderson <=
- [Qemu-devel] [PATCH 14/19] nvic: Disable the non-secure HardFault if AIRCR.BFHFNMINS is clear, Peter Maydell, 2017/09/12
- [Qemu-devel] [PATCH 10/19] nvic: Make SHPR registers banked, Peter Maydell, 2017/09/12
- [Qemu-devel] [PATCH 13/19] nvic: Implement v8M changes to fixed priority exceptions, Peter Maydell, 2017/09/12
- [Qemu-devel] [PATCH 19/19] nvic: Support banked exceptions in acknowledge and complete, Peter Maydell, 2017/09/12
- [Qemu-devel] [PATCH 18/19] nvic: Make SHCSR banked for v8M, Peter Maydell, 2017/09/12