[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 02/10] migratiom: Remove max_item_age parameter
From: |
Peter Xu |
Subject: |
Re: [Qemu-devel] [PATCH 02/10] migratiom: Remove max_item_age parameter |
Date: |
Thu, 12 Oct 2017 13:46:32 +0800 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Tue, Oct 10, 2017 at 08:15:34PM +0200, Juan Quintela wrote:
> It was not used at all since commit:
>
> 27af7d6ea5015e5ef1f7985eab94a8a218267a2b
>
> which replaced its use by the dirty sync count.
>
> Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Peter Xu <address@hidden>
> ---
> migration/page_cache.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/migration/page_cache.c b/migration/page_cache.c
> index ba984c4858..381e555ddb 100644
> --- a/migration/page_cache.c
> +++ b/migration/page_cache.c
> @@ -41,7 +41,6 @@ struct PageCache {
> CacheItem *page_cache;
> unsigned int page_size;
> int64_t max_num_items;
> - uint64_t max_item_age;
> int64_t num_items;
> };
>
> @@ -69,7 +68,6 @@ PageCache *cache_init(int64_t num_pages, unsigned int
> page_size)
> }
> cache->page_size = page_size;
> cache->num_items = 0;
> - cache->max_item_age = 0;
> cache->max_num_items = num_pages;
>
> DPRINTF("Setting cache buckets to %" PRId64 "\n", cache->max_num_items);
> --
> 2.13.6
>
--
Peter Xu
- [Qemu-devel] [PATCH 00/10] Make xbzrle_cache_size a migration parameter, Juan Quintela, 2017/10/10
- [Qemu-devel] [PATCH 01/10] migration: Fix migrate_test_apply for multifd parameters, Juan Quintela, 2017/10/10
- [Qemu-devel] [PATCH 02/10] migratiom: Remove max_item_age parameter, Juan Quintela, 2017/10/10
- Re: [Qemu-devel] [PATCH 02/10] migratiom: Remove max_item_age parameter,
Peter Xu <=
- [Qemu-devel] [PATCH 03/10] migration: Make cache size elements use the right types, Juan Quintela, 2017/10/10
- [Qemu-devel] [PATCH 04/10] migration: Move xbzrle cache resize error handling to xbzrle_cache_resize, Juan Quintela, 2017/10/10
- [Qemu-devel] [PATCH 05/10] migration: Make cache_init() take an error parameter, Juan Quintela, 2017/10/10
- [Qemu-devel] [PATCH 07/10] migration: Don't play games with the requested cache size, Juan Quintela, 2017/10/10
- [Qemu-devel] [PATCH 06/10] migration: Make sure that we pass the right cache size, Juan Quintela, 2017/10/10