[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 03/10] migration: Make cache size elements use t
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-devel] [PATCH 03/10] migration: Make cache size elements use the right types |
Date: |
Thu, 12 Oct 2017 11:01:28 +0100 |
User-agent: |
Mutt/1.9.1 (2017-09-22) |
* Juan Quintela (address@hidden) wrote:
> Signed-off-by: Juan Quintela <address@hidden>
> ---
> migration/page_cache.c | 8 ++++----
> migration/page_cache.h | 2 +-
> 2 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/migration/page_cache.c b/migration/page_cache.c
> index 381e555ddb..6b2dd77cf0 100644
> --- a/migration/page_cache.c
> +++ b/migration/page_cache.c
> @@ -39,12 +39,12 @@ struct CacheItem {
>
> struct PageCache {
> CacheItem *page_cache;
> - unsigned int page_size;
> - int64_t max_num_items;
> - int64_t num_items;
> + size_t page_size;
> + size_t max_num_items;
> + size_t num_items;
> };
>
> -PageCache *cache_init(int64_t num_pages, unsigned int page_size)
> +PageCache *cache_init(size_t num_pages, size_t page_size)
> {
> int64_t i;
>
> diff --git a/migration/page_cache.h b/migration/page_cache.h
> index 4fadd0c501..931868b857 100644
> --- a/migration/page_cache.h
> +++ b/migration/page_cache.h
> @@ -28,7 +28,7 @@ typedef struct PageCache PageCache;
> * @num_pages: cache maximal number of cached pages
> * @page_size: cache page size
> */
> -PageCache *cache_init(int64_t num_pages, unsigned int page_size);
> +PageCache *cache_init(size_t num_pages, size_t page_size);
Makes sense; have you checked that the build is happy on 32bit
machines with xbzrle_cache_resize still passing an int64_t at this
point?
However, it's the right thing to move to, so:
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
> /**
> * cache_fini: free all cache resources
> --
> 2.13.6
>
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK
- [Qemu-devel] [PATCH 00/10] Make xbzrle_cache_size a migration parameter, Juan Quintela, 2017/10/10
- [Qemu-devel] [PATCH 01/10] migration: Fix migrate_test_apply for multifd parameters, Juan Quintela, 2017/10/10
- [Qemu-devel] [PATCH 02/10] migratiom: Remove max_item_age parameter, Juan Quintela, 2017/10/10
- [Qemu-devel] [PATCH 03/10] migration: Make cache size elements use the right types, Juan Quintela, 2017/10/10
- Re: [Qemu-devel] [PATCH 03/10] migration: Make cache size elements use the right types,
Dr. David Alan Gilbert <=
- [Qemu-devel] [PATCH 04/10] migration: Move xbzrle cache resize error handling to xbzrle_cache_resize, Juan Quintela, 2017/10/10
- [Qemu-devel] [PATCH 05/10] migration: Make cache_init() take an error parameter, Juan Quintela, 2017/10/10
- [Qemu-devel] [PATCH 07/10] migration: Don't play games with the requested cache size, Juan Quintela, 2017/10/10
- [Qemu-devel] [PATCH 06/10] migration: Make sure that we pass the right cache size, Juan Quintela, 2017/10/10
- [Qemu-devel] [PATCH 08/10] migration: No need to return the size of the cache, Juan Quintela, 2017/10/10
- [Qemu-devel] [PATCH 09/10] migration: Make xbzrle_cache_size a migration parameter, Juan Quintela, 2017/10/10