[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 35/38] qom: Add MMU_DEBUG_LOAD
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH 35/38] qom: Add MMU_DEBUG_LOAD |
Date: |
Fri, 29 Dec 2017 17:18:06 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 |
Hi,
Since you're specifically CC'ing me, some nits:
Am 29.12.2017 um 07:31 schrieb Richard Henderson:
> This lets us tell bottom levels of virtual memory translation
> routines that the access is from within QEMU itself and bypass
> certain tests.
This sentence could use a tweak for clarity: tell bottom levels of
virtual memory translation routines ... to bypass? or that the access
... bypasses? or that this lets us ... bypass?
>
> Cc: Andreas Färber <address@hidden>
> Signed-off-by: Richard Henderson <address@hidden>
> ---
> include/qom/cpu.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/include/qom/cpu.h b/include/qom/cpu.h
> index c2fa151228..d5361ffd0e 100644
> --- a/include/qom/cpu.h
> +++ b/include/qom/cpu.h
> @@ -64,7 +64,8 @@ typedef uint64_t vaddr;
> typedef enum MMUAccessType {
> MMU_DATA_LOAD = 0,
> MMU_DATA_STORE = 1,
> - MMU_INST_FETCH = 2
> + MMU_INST_FETCH = 2,
> + MMU_DEBUG_LOAD = 3
Given that you had to touch the previous line for your comma, it would
be advisable to add one on the new line to avoid that next time.
> } MMUAccessType;
>
> typedef struct CPUWatchpoint CPUWatchpoint;
Either way please take the patch through a suitable tree.
Cheers,
Andreas
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
- [Qemu-devel] [PATCH 28/38] target/hppa: Implement a halt instruction, (continued)
- [Qemu-devel] [PATCH 28/38] target/hppa: Implement a halt instruction, Richard Henderson, 2017/12/29
- [Qemu-devel] [PATCH 27/38] target/hppa: Implement SYNCDMA insn, Richard Henderson, 2017/12/29
- [Qemu-devel] [PATCH 26/38] target/hppa: Implement LCI, Richard Henderson, 2017/12/29
- [Qemu-devel] [PATCH 31/38] target/hppa: Add system registers to gdbstub, Richard Henderson, 2017/12/29
- [Qemu-devel] [PATCH 32/38] target/hppa: Add migration for the cpu, Richard Henderson, 2017/12/29
- [Qemu-devel] [PATCH 29/38] hw/hppa: Implement DINO system board, Richard Henderson, 2017/12/29
- [Qemu-devel] [PATCH 30/38] target/hppa: Optimize for flat addressing space, Richard Henderson, 2017/12/29
- [Qemu-devel] [PATCH 33/38] target/hppa: Implement B,GATE insn, Richard Henderson, 2017/12/29
- [Qemu-devel] [PATCH 35/38] qom: Add MMU_DEBUG_LOAD, Richard Henderson, 2017/12/29
- Re: [Qemu-devel] [PATCH 35/38] qom: Add MMU_DEBUG_LOAD,
Andreas Färber <=
- [Qemu-devel] [PATCH 34/38] target/hppa: Only use EXCP_DTLB_MISS, Richard Henderson, 2017/12/29
- [Qemu-devel] [PATCH 36/38] target/hppa: Use MMU_DEBUG_LOAD when reloading for CR[IIR], Richard Henderson, 2017/12/29
- [Qemu-devel] [PATCH 37/38] target/hppa: Increase number of temp regs, Richard Henderson, 2017/12/29
- [Qemu-devel] [PATCH 38/38] target/hppa: Fix comment, Richard Henderson, 2017/12/29