[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH RFC 12/21] qapi: Concentrate QAPISchemaParser.ex
|
From: |
Markus Armbruster |
|
Subject: |
Re: [Qemu-devel] [PATCH RFC 12/21] qapi: Concentrate QAPISchemaParser.exprs updates in .__init__() |
|
Date: |
Mon, 05 Feb 2018 15:26:38 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) |
Marc-Andre Lureau <address@hidden> writes:
> On Fri, Feb 2, 2018 at 2:03 PM, Markus Armbruster <address@hidden> wrote:
>> Signed-off-by: Markus Armbruster <address@hidden>
>
> It's not obvious the motivation behind this change (beside behind more
> elegant), but
At one point during my search for a good way to record includes in the
parse tree, updating .exprs in two places got in the way, so I cleaned
it up. I guess it's not in the way of the solution I eventually chose,
but I consider it a worthwhile little cleanup on its own.
> Reviewed-by: Marc-André Lureau <address@hidden>
Thanks!
- [Qemu-devel] [PATCH RFC 21/21] qapi: Empty out qapi-schema.json, (continued)
- [Qemu-devel] [PATCH RFC 21/21] qapi: Empty out qapi-schema.json, Markus Armbruster, 2018/02/02
- [Qemu-devel] [PATCH RFC 04/21] qapi: Reduce use of global variables in generators some, Markus Armbruster, 2018/02/02
- [Qemu-devel] [PATCH RFC 18/21] qapi/common: Fix guardname() for funny filenames, Markus Armbruster, 2018/02/02
- [Qemu-devel] [PATCH RFC 12/21] qapi: Concentrate QAPISchemaParser.exprs updates in .__init__(), Markus Armbruster, 2018/02/02
- [Qemu-devel] [PATCH RFC 08/21] qapi: Touch generated files only when they change, Markus Armbruster, 2018/02/02
- [Qemu-devel] [PATCH RFC 20/21] Include less of qapi-types.h, Markus Armbruster, 2018/02/02
- [Qemu-devel] [PATCH RFC 16/21] qapi/types qapi/visit: Make visitors use QAPIGen more, Markus Armbruster, 2018/02/02
- [Qemu-devel] [PATCH RFC 05/21] qapi: Turn generators into modules, Markus Armbruster, 2018/02/02