Re: [Qemu-devel] [PATCH RFC 20/21] Include less of qapi-types.h

[Markus Armbruster]

Marc-Andre Lureau <address@hidden> writes:

> On Fri, Feb 2, 2018 at 2:03 PM, Markus Armbruster <address@hidden> wrote:
>> In my "build everything" tree, a change to the types in
>> qapi-schema.json triggers a recompile of about 4500 out of 4800
>> objects.
>>
>> The previous commit split up the generated qapi-types.h.  Replace
>> includes of qapi-types.h (i.e. all types) by includes of parts where
>> possible.
>>
>> To illustrate the benefits: adding a type to qapi/migration.json now
>> recompiles some 2300 instead of 4500 objects.  The next commit will
>> improve it further.
>>
>> Signed-off-by: Markus Armbruster <address@hidden>
>
> for the record, what was your methodology?

I counted compiles like this:

    $ make 2>&1 | awk '/^  [A-Z]/ { h[$1]++ } END { n = asorti(h, x); for (i = 
1; i <=n; i++) print x[i], h[x[i]] }'

> Reviewed-by: Marc-André Lureau <address@hidden>

Thanks!