[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1 09/29] target-microblaze: Conditionalize sett
From: |
Alistair Francis |
Subject: |
Re: [Qemu-devel] [PATCH v1 09/29] target-microblaze: Conditionalize setting of PVR11_USE_MMU |
Date: |
Thu, 03 May 2018 20:18:51 +0000 |
On Thu, May 3, 2018 at 2:22 AM Edgar E. Iglesias <address@hidden>
wrote:
> From: "Edgar E. Iglesias" <address@hidden>
> Conditionalize setting of PVR11_USE_MMU on the use_mmu
> CPU property, otherwise we may incorrectly advertise an
> MMU via PVR when the core in fact has none.
> Signed-off-by: Edgar E. Iglesias <address@hidden>
Reviewed-by: Alistair Francis <address@hidden>
Alistair
> ---
> target/microblaze/cpu.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
> diff --git a/target/microblaze/cpu.c b/target/microblaze/cpu.c
> index 06476f6efc..6fdf0fd223 100644
> --- a/target/microblaze/cpu.c
> +++ b/target/microblaze/cpu.c
> @@ -201,7 +201,8 @@ static void mb_cpu_realizefn(DeviceState *dev, Error
**errp)
> PVR5_DCACHE_WRITEBACK_MASK : 0;
> env->pvr.regs[10] = 0x0c000000; /* Default to spartan 3a dsp family.
*/
> - env->pvr.regs[11] = PVR11_USE_MMU | (16 << 17);
> + env->pvr.regs[11] = cpu->cfg.use_mmu ? PVR11_USE_MMU : 0 |
> + 16 << 17;
> mcc->parent_realize(dev, errp);
> }
> --
> 2.14.1
- [Qemu-devel] [PATCH v1 03/29] target-microblaze: compute_ldst_addr: Use bool instead of int, (continued)
- [Qemu-devel] [PATCH v1 03/29] target-microblaze: compute_ldst_addr: Use bool instead of int, Edgar E. Iglesias, 2018/05/03
- [Qemu-devel] [PATCH v1 04/29] target-microblaze: Fallback to our latest CPU version, Edgar E. Iglesias, 2018/05/03
- [Qemu-devel] [PATCH v1 05/29] target-microblaze: Correct special register array sizes, Edgar E. Iglesias, 2018/05/03
- [Qemu-devel] [PATCH v1 06/29] target-microblaze: Correct the PVR array size, Edgar E. Iglesias, 2018/05/03
- [Qemu-devel] [PATCH v1 09/29] target-microblaze: Conditionalize setting of PVR11_USE_MMU, Edgar E. Iglesias, 2018/05/03
- Re: [Qemu-devel] [PATCH v1 09/29] target-microblaze: Conditionalize setting of PVR11_USE_MMU,
Alistair Francis <=
- [Qemu-devel] [PATCH v1 08/29] target-microblaze: Remove USE_MMU PVR checks, Edgar E. Iglesias, 2018/05/03
- [Qemu-devel] [PATCH v1 10/29] target-microblaze: Bypass MMU with MMU_NOMMU_IDX, Edgar E. Iglesias, 2018/05/03
- [Qemu-devel] [PATCH v1 07/29] target-microblaze: Tighten up TCGv_i32 vs TCGv type usage, Edgar E. Iglesias, 2018/05/03
- [Qemu-devel] [PATCH v1 11/29] target-microblaze: Make compute_ldst_addr always use a temp, Edgar E. Iglesias, 2018/05/03