qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 3/3] glib: enforce the minimum required version


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH 3/3] glib: enforce the minimum required version and warn about old APIs
Date: Tue, 8 May 2018 18:02:55 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0

On 08/05/2018 17:19, Daniel P. Berrangé wrote:
> Ok, that change looks fine with me assuming it passes your build tests.
> In fact that is what I had done in an earlier version.
> 
> Regards,
> Daniel

Actually there is a use of g_strv_contains in tests/test-qga.c.  It is
guarded by GLIB_CHECK_VERSION(2, 44, 0) but the right fix should be to
include the compatibility function instead.

For now I am dropping this patch.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]