[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v7 0/4] monitor: let Monitor be thread safe
From: |
no-reply |
Subject: |
Re: [Qemu-devel] [PATCH v7 0/4] monitor: let Monitor be thread safe |
Date: |
Wed, 23 May 2018 21:46:11 -0700 (PDT) |
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PATCH v7 0/4] monitor: let Monitor be thread safe
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
t [tag update] patchew/address@hidden -> patchew/address@hidden
* [new tag] patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
dadcba2375 monitor: add lock to protect mon_fdsets
eda66671b9 monitor: more comments on lock-free fleids/funcs
b7d356e160 monitor: protect mon->fds with mon_lock
35eadfaff2 monitor: rename out_lock to mon_lock
=== OUTPUT BEGIN ===
Checking PATCH 1/4: monitor: rename out_lock to mon_lock...
Checking PATCH 2/4: monitor: protect mon->fds with mon_lock...
Checking PATCH 3/4: monitor: more comments on lock-free fleids/funcs...
ERROR: do not use C99 // comments
#28: FILE: monitor.c:218:
+ // other members that aren't shared
total: 1 errors, 0 warnings, 31 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 4/4: monitor: add lock to protect mon_fdsets...
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden
- Re: [Qemu-devel] [PATCH v7 3/4] monitor: more comments on lock-free fleids/funcs, (continued)
[Qemu-devel] [PATCH v7 4/4] monitor: add lock to protect mon_fdsets, Peter Xu, 2018/05/24
Re: [Qemu-devel] [PATCH v7 0/4] monitor: let Monitor be thread safe,
no-reply <=