[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v7 1/4] monitor: rename out_lock to mon_lock
From: |
Peter Xu |
Subject: |
Re: [Qemu-devel] [PATCH v7 1/4] monitor: rename out_lock to mon_lock |
Date: |
Thu, 24 May 2018 16:45:48 +0800 |
User-agent: |
Mutt/1.9.5 (2018-04-13) |
On Thu, May 24, 2018 at 10:29:20AM +0200, Markus Armbruster wrote:
> Peter Xu <address@hidden> writes:
>
> > The out_lock is protecting a few Monitor fields. In the future the
> > monitor code will start to run in multiple threads. We are going to
> > turn it into a bigger lock to protect not only the out buffer but also
> > all the rest.
>
> Hmm, not sure about "all the rest": PATCH 3 marks a member as not
> needing protection. Shall I change this to "most of the rest" when I
> apply?
Of course. :) Please feel free to touch up the commit message where
necessary (this rule applies to all my patches). I fully trust your
wordings.
Thanks!
--
Peter Xu
[Qemu-devel] [PATCH v7 4/4] monitor: add lock to protect mon_fdsets, Peter Xu, 2018/05/24