[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 16/20] colo: use local path for local headers
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-devel] [PATCH v2 16/20] colo: use local path for local headers |
Date: |
Sat, 26 May 2018 01:31:20 -0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 |
On 05/25/2018 01:48 PM, Michael S. Tsirkin wrote:
> When pulling in headers that are in the same directory as C file (as
> opposed to one in include/), we should use its relative path, without a
> directory.
>
> Reviewed-by: Zhang Chen <address@hidden>
> Signed-off-by: Michael S. Tsirkin <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Tested-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> net/colo-compare.c | 2 +-
> net/colo.c | 2 +-
> net/filter-rewriter.c | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/net/colo-compare.c b/net/colo-compare.c
> index 23b2d2c..c3a2be4 100644
> --- a/net/colo-compare.c
> +++ b/net/colo-compare.c
> @@ -25,7 +25,7 @@
> #include "net/queue.h"
> #include "chardev/char-fe.h"
> #include "qemu/sockets.h"
> -#include "net/colo.h"
> +#include "colo.h"
> #include "sysemu/iothread.h"
>
> #define TYPE_COLO_COMPARE "colo-compare"
> diff --git a/net/colo.c b/net/colo.c
> index 8426265..6dda4ed 100644
> --- a/net/colo.c
> +++ b/net/colo.c
> @@ -14,7 +14,7 @@
>
> #include "qemu/osdep.h"
> #include "trace.h"
> -#include "net/colo.h"
> +#include "colo.h"
>
> uint32_t connection_key_hash(const void *opaque)
> {
> diff --git a/net/filter-rewriter.c b/net/filter-rewriter.c
> index 62dad2d..f584e4e 100644
> --- a/net/filter-rewriter.c
> +++ b/net/filter-rewriter.c
> @@ -11,7 +11,7 @@
>
> #include "qemu/osdep.h"
> #include "trace.h"
> -#include "net/colo.h"
> +#include "colo.h"
> #include "net/filter.h"
> #include "net/net.h"
> #include "qemu-common.h"
>
- Re: [Qemu-devel] [PATCH v2 10/20] rocker: drop an unused include, (continued)
- [Qemu-devel] [PATCH v2 11/20] ppc: use local path for local headers, Michael S. Tsirkin, 2018/05/25
- [Qemu-devel] [PATCH v2 12/20] vhost-scsi: drop an unused include, Michael S. Tsirkin, 2018/05/25
- [Qemu-devel] [PATCH v2 13/20] sd: fix up include, Michael S. Tsirkin, 2018/05/25
- [Qemu-devel] [PATCH v2 14/20] usb: use local path for local headers, Michael S. Tsirkin, 2018/05/25
- [Qemu-devel] [PATCH v2 16/20] colo: use local path for local headers, Michael S. Tsirkin, 2018/05/25
- Re: [Qemu-devel] [PATCH v2 16/20] colo: use local path for local headers,
Philippe Mathieu-Daudé <=
- [Qemu-devel] [PATCH v2 17/20] qga: use local path for local headers, Michael S. Tsirkin, 2018/05/25
- [Qemu-devel] [PATCH v2 15/20] migration: use local path for local headers, Michael S. Tsirkin, 2018/05/25
- [Qemu-devel] [PATCH v2 18/20] trace: use local path for local headers, Michael S. Tsirkin, 2018/05/25
- [Qemu-devel] [PATCH v2 19/20] ui: use local path for local headers, Michael S. Tsirkin, 2018/05/25
- [Qemu-devel] [PATCH v2 20/20] arch_init: sort architectures, Michael S. Tsirkin, 2018/05/25