[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/5] pr-manager: add query-pr-managers QMP comma
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 4/5] pr-manager: add query-pr-managers QMP command |
Date: |
Thu, 28 Jun 2018 09:08:39 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 |
On 28/06/2018 09:05, Michal Prívozník wrote:
>> qemu-pr-helper anyway does something only when a guests sends it a PR
>> command - and with libvirt's per-guest model, that would (hopefully)
>> mean that the only case that remains is when someone manually kills the
>> qemu-pr-helper process. In that case there's a certain amount of PEBKAC
>> involved... :)
>
> Unless an assert() is triggered ;-)
Indeed, but that should still happen "when a guest sends it a PR
command". The problematic case would only arise if qemu-pr-helper
crashes between the last time QEMU sent a command, and the time libvirt
sends query-pr-managers.
> But since you merged my suggested changes in 5/5 libvirt can catch the
> event pretty soon, so in my testing qemu was still left with 3-4
> connection retries which is plenty.
Good, thanks.
Paolo
[Qemu-devel] [PATCH 2/5] pr-helper: fix assertion failure on failed multipath PERSISTENT RESERVE IN, Paolo Bonzini, 2018/06/26
[Qemu-devel] [PATCH 5/5] pr-manager-helper: report event on connection/disconnection, Paolo Bonzini, 2018/06/26