Re: [Qemu-devel] [PATCH 4/6] target/arm: Prune a15 features from max

[Philippe Mathieu-Daudé]

On 06/28/2018 09:15 PM, Richard Henderson wrote:
> There is no need to re-set these 3 features already
> implied by the call to aarch64_a15_initfn.
> 
> Signed-off-by: Richard Henderson <address@hidden>

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>

> ---
>  target/arm/cpu.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/target/arm/cpu.c b/target/arm/cpu.c
> index aa62315cea..878cc6c7e8 100644
> --- a/target/arm/cpu.c
> +++ b/target/arm/cpu.c
> @@ -1796,9 +1796,6 @@ static void arm_max_initfn(Object *obj)
>           * since we don't correctly set the ID registers to advertise them,
>           */
>          set_feature(&cpu->env, ARM_FEATURE_V8);
> -        set_feature(&cpu->env, ARM_FEATURE_VFP4);
> -        set_feature(&cpu->env, ARM_FEATURE_NEON);
> -        set_feature(&cpu->env, ARM_FEATURE_THUMB2EE);
>          set_feature(&cpu->env, ARM_FEATURE_V8_AES);
>          set_feature(&cpu->env, ARM_FEATURE_V8_SHA1);
>          set_feature(&cpu->env, ARM_FEATURE_V8_SHA256);
>