Re: [Qemu-devel] ?==?utf-8?q? [PATCH v3 3/8] target/mips: Update some CP0 registers bit definitions

[Aleksandar Markovic]

Hi, Philippe!

I truly appreciate your review.

> > #define CP0C5_EVA 28
> > #define CP0C5_MSAEn 27
> > +#define CP0C5_PMJ2 25
> > +#define CP0C5_PMJ1 24
> > +#define CP0C5_PMJ0 23
>
> Why not use:
>
> #define CP0C5_PMJ 23 /* 25..23 */
>

I now think that the way you suggested here is better, and will integrate it in 
v4.

> > +#define CP0C5_WR2 22
> > +#define CP0C5_NMS 21
> > +#define CP0C5_ULS 20
> > +#define CP0C5_XPA 19
> > +#define CP0C5_CRCP 18
> > +#define CP0C5_MI 17
> > +#define CP0C5_GI1 16
> > +#define CP0C5_GI0 15
>
> Ditto:
>
> #define CP0C5_GI 15 /* 16..15 */
>

The same.

> > +#define CP0C5_CA2 14
> > #define CP0C5_XNP 13
> > +#define CP0C5_DEC 11

Sincerely,
Aleksandar