[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1] s390x/cpu_models: Add "-cpu max" support
From: |
David Hildenbrand |
Subject: |
Re: [Qemu-devel] [PATCH v1] s390x/cpu_models: Add "-cpu max" support |
Date: |
Wed, 25 Jul 2018 14:49:45 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 |
>>
>>> Maybe add a comment that for kvm we try the host model, and only that
>>> can fail (i.e., for tcg this will always work)?
>>
>> "we expect only errors under KVM, when we actually query the kernel"
>
> "We expect errors only under KVM, where we actually query the kernel"
>
> ?
Sure, maybe you can fit it into one line (which is what I tried).
>
> If nobody else has further comments, I can squash in the change and
> queue it for 3.1. I'll let it sit for a bit longer on the list, though.
If I don't have to resend, can you fixup the subject "s390x/cpumodel: ..." ?
Thanks!
--
Thanks,
David / dhildenb
Re: [Qemu-devel] [PATCH v1] s390x/cpu_models: Add "-cpu max" support, Eduardo Habkost, 2018/07/25
Re: [Qemu-devel] [PATCH v1] s390x/cpu_models: Add "-cpu max" support, Cornelia Huck, 2018/07/27