Re: [Qemu-devel] [PATCH 4/6] cpus: initialize timers_state.vm_clock_lock

[Alex Bennée]

Emilio G. Cota <address@hidden> writes:

> We forgot to initialize the spinlock introduced in 94377115b2
> ("cpus: protect TimerState writes with a spinlock", 2018-08-23).
> Fix it.
>
> Signed-off-by: Emilio G. Cota <address@hidden>
> ---
>  cpus.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/cpus.c b/cpus.c
> index 8ee6e5db93..ebc13bac2d 100644
> --- a/cpus.c
> +++ b/cpus.c
> @@ -823,6 +823,7 @@ int cpu_throttle_get_percentage(void)
>  void cpu_ticks_init(void)
>  {
>      seqlock_init(&timers_state.vm_clock_seqlock);
> +    qemu_spin_init(&timers_state.vm_clock_lock);
>      vmstate_register(NULL, 0, &vmstate_timers, &timers_state);
>      throttle_timer = timer_new_ns(QEMU_CLOCK_VIRTUAL_RT,
>                                             cpu_throttle_timer_tick, NULL);


Reviewed-by: Alex Bennée <address@hidden>

-- 
Alex Bennée