[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 4/4] softfloat: Specialize udiv_qrnnd for ppc
From: |
David Gibson |
Subject: |
Re: [Qemu-devel] [PATCH v2 4/4] softfloat: Specialize udiv_qrnnd for ppc64 |
Date: |
Thu, 4 Oct 2018 10:18:48 +1000 |
User-agent: |
Mutt/1.10.1 (2018-07-13) |
On Wed, Oct 03, 2018 at 01:07:11PM -0500, Richard Henderson wrote:
> The ISA has a 128/64-bit division instruction, though it assumes the
> low 64-bits of the numerator are 0, and so requires a bit more fixup
> than a full 128-bit division insn.
>
> Cc: address@hidden
> Cc: Alexander Graf <address@hidden>
> Cc: David Gibson <address@hidden>
> Signed-off-by: Richard Henderson <address@hidden>
Reviewed-by: David Gibson <address@hidden>
> ---
> include/fpu/softfloat-macros.h | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/include/fpu/softfloat-macros.h b/include/fpu/softfloat-macros.h
> index e702607b43..001bf4f23c 100644
> --- a/include/fpu/softfloat-macros.h
> +++ b/include/fpu/softfloat-macros.h
> @@ -632,6 +632,22 @@ static inline uint64_t udiv_qrnnd(uint64_t *r, uint64_t
> n1,
> asm("dlgr %0, %1" : "+r"(n) : "r"(d));
> *r = n >> 64;
> return n;
> +#elif defined(_ARCH_PPC64)
> + /* From Power ISA 3.0B, programming note for divdeu. */
> + uint64_t q1, q2, Q, r1, r2, R;
> + asm("divdeu %0,%2,%4; divdu %1,%3,%4"
> + : "=&r"(q1), "=r"(q2)
> + : "r"(n1), "r"(n0), "r"(d));
> + r1 = -(q1 * d); /* low part of (n1<<64) - (q1 * d) */
> + r2 = n0 - (q2 * d);
> + Q = q1 + q2;
> + R = r2 + r1;
> + if (R < r2 || R >= d) { /* overflow implies R > d */
> + Q += 1;
> + R -= d;
> + }
> + *r = R;
> + return Q;
> #else
> uint64_t d0, d1, q0, q1, r1, r0, m;
>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
- [Qemu-devel] [PATCH v2 0/4] softfloat: Fix division, Richard Henderson, 2018/10/03
- [Qemu-devel] [PATCH v2 3/4] softfloat: Specialize udiv_qrnnd for s390x, Richard Henderson, 2018/10/03
- [Qemu-devel] [PATCH v2 2/4] softfloat: Specialize udiv_qrnnd for x86_64, Richard Henderson, 2018/10/03
- [Qemu-devel] [PATCH v2 4/4] softfloat: Specialize udiv_qrnnd for ppc64, Richard Henderson, 2018/10/03
- Re: [Qemu-devel] [PATCH v2 4/4] softfloat: Specialize udiv_qrnnd for ppc64,
David Gibson <=
- [Qemu-devel] [PATCH v2 1/4] softfloat: Fix division, Richard Henderson, 2018/10/03
- Re: [Qemu-devel] [PATCH v2 0/4] softfloat: Fix division, Alex Bennée, 2018/10/04