[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 0/4] softfloat: Fix division
From: |
Alex Bennée |
Subject: |
Re: [Qemu-devel] [PATCH v2 0/4] softfloat: Fix division |
Date: |
Thu, 04 Oct 2018 16:43:23 +0100 |
User-agent: |
mu4e 1.1.0; emacs 26.1.50 |
Emilio G. Cota <address@hidden> writes:
> On Thu, Oct 04, 2018 at 10:13:55 +0100, Alex Bennée wrote:
>>
>> Richard Henderson <address@hidden> writes:
>>
>> > Changes from v1:
>> > * Preserve udiv_qrnnd as a separate division primitive that
>> > could be used as a building block for float128 division.
>> > * Include asm fragments for x86_64, s390x, and ppc64.
>>
>> It passes my fops fdiv_double test but Emilio's test is reporting:
>>
>> Errors found in f64_div, rounding near_even:
>> +252.7FFFFFFFFFF80 +001.FFFFFFFFFFFFE
>> => +64F.7FFFFFFFFFF82 ....x expected +64F.7FFFFFFFFFF81 ....x
>
> Did you rebuild the test program? v2 passes all f64_div tests for me.
>
> Tested-by: Emilio G. Cota <address@hidden>
> for patches 1 and 2.
Hmm I did:
make clean
make
in the tests/fp dir multiple times while going through before/after fix
scenarios. And now of course it works....
Reviewed-by: Alex Bennée <address@hidden>
Tested-by: Alex Bennée <address@hidden>
>
> Thanks,
>
> E.
--
Alex Bennée
- [Qemu-devel] [PATCH v2 0/4] softfloat: Fix division, Richard Henderson, 2018/10/03
- [Qemu-devel] [PATCH v2 3/4] softfloat: Specialize udiv_qrnnd for s390x, Richard Henderson, 2018/10/03
- [Qemu-devel] [PATCH v2 2/4] softfloat: Specialize udiv_qrnnd for x86_64, Richard Henderson, 2018/10/03
- [Qemu-devel] [PATCH v2 4/4] softfloat: Specialize udiv_qrnnd for ppc64, Richard Henderson, 2018/10/03
- [Qemu-devel] [PATCH v2 1/4] softfloat: Fix division, Richard Henderson, 2018/10/03
- Re: [Qemu-devel] [PATCH v2 0/4] softfloat: Fix division, Alex Bennée, 2018/10/04