[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 05/11] hw/m68k: Apple Sound Chip (ASC) emulat
From: |
Laurent Vivier |
Subject: |
Re: [Qemu-devel] [PATCH v5 05/11] hw/m68k: Apple Sound Chip (ASC) emulation |
Date: |
Tue, 30 Oct 2018 13:05:23 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 |
Le 30/10/2018 à 11:46, Mark Cave-Ayland a écrit :
> On 30/10/2018 06:46, Hervé Poussineau wrote:
>
>> Le 29/10/2018 à 14:39, Mark Cave-Ayland a écrit :
>>> From: Laurent Vivier <address@hidden>
>>>
>>> This is broken as the linux driver seems broken too...
>>>
>>> Co-developed-by: Mark Cave-Ayland <address@hidden>
>>> Signed-off-by: Mark Cave-Ayland <address@hidden>
>>> Signed-off-by: Laurent Vivier <address@hidden>
>>> ---
>>> hw/audio/Makefile.objs | 1 +
>>> hw/audio/asc.c | 446
>>> +++++++++++++++++++++++++++++++++++++++++++++++++
>>> include/hw/audio/asc.h | 48 ++++++
>>> 3 files changed, 495 insertions(+)
>>> create mode 100644 hw/audio/asc.c
>>> create mode 100644 include/hw/audio/asc.h
>>
>> According to above comment, this device is broken.
>> Is it necessary for Q800 emulation? What happens if you remove it?
>
> A quick test here shows that I can still boot without it, so it doesn't seem
> to be
> essential. Laurent, should we remove this from the next revision of the
> patchset? The
> general consensus seems to be that if a device isn't required (for now) then
> it
> shouldn't be included.
It can be removed.
I've just checked the kernel and in the case of the Quadra 800 the ASC
is not supported at all.
Thanks,
Laurent
- [Qemu-devel] [PATCH v5 06/11] esp: add pseudo-DMA as used by Macintosh, (continued)
- [Qemu-devel] [PATCH v5 07/11] hw/m68k: add Nubus support, Mark Cave-Ayland, 2018/10/29
- [Qemu-devel] [PATCH v5 08/11] hw/m68k: add Nubus support for macfb video card, Mark Cave-Ayland, 2018/10/29
- [Qemu-devel] [PATCH v5 09/11] hw/m68k: add a dummy SWIM floppy controller, Mark Cave-Ayland, 2018/10/29
- [Qemu-devel] [PATCH v5 11/11] hw/m68k: define Macintosh Quadra 800, Mark Cave-Ayland, 2018/10/29
- [Qemu-devel] [PATCH v5 10/11] dp8393x: manage big endian bus, Mark Cave-Ayland, 2018/10/29