[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/2] acpi: RSDP: fix checksum calculations
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH 0/2] acpi: RSDP: fix checksum calculations |
Date: |
Fri, 23 Nov 2018 11:11:50 -0500 |
On Thu, Nov 22, 2018 at 11:29:32AM +0100, Igor Mammedov wrote:
> * arm/virt is broken but it looks like linux doesn't care, lets fix it
> anyways
> * x86, got lucky since we didn't use extended fields,
> fix it so that it will calculate checksum using correct length
> so that it would be easier to unify arm/x86 into one impl.
>
I'd say patch 2 should go into this release.
What about patch 1? It's cosmetic and it isn't the best we can do.
Let me know whether you agree.
> Igor Mammedov (2):
> pc: acpi: use correct RSDT length for checksum
> arm/virt: acpi: fix incorrect checksums in RSDP
>
> hw/arm/virt-acpi-build.c | 7 ++++++-
> hw/i386/acpi-build.c | 2 +-
> 2 files changed, 7 insertions(+), 2 deletions(-)
>
> --
> 2.7.4