[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 03/21] target/arm: Stop unintentional sign extension
From: |
Peter Maydell |
Subject: |
[Qemu-devel] [PULL 03/21] target/arm: Stop unintentional sign extension in pmu_init |
Date: |
Thu, 21 Feb 2019 18:57:21 +0000 |
From: Aaron Lindsay OS <address@hidden>
This was introduced by
commit bf8d09694ccc07487cd73d7562081fdaec3370c8
target/arm: Don't clear supported PMU events when initializing PMCEID1
and identified by Coverity (CID 1398645).
Signed-off-by: Aaron Lindsay <address@hidden>
Reported-by: Peter Maydell <address@hidden>
Message-id: address@hidden
Reviewed-by: Peter Maydell <address@hidden>
Signed-off-by: Peter Maydell <address@hidden>
---
target/arm/helper.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/arm/helper.c b/target/arm/helper.c
index fe054897c78..c2630fa1ea4 100644
--- a/target/arm/helper.c
+++ b/target/arm/helper.c
@@ -1167,7 +1167,7 @@ void pmu_init(ARMCPU *cpu)
if (cnt->supported(&cpu->env)) {
supported_event_map[cnt->number] = i;
- uint64_t event_mask = 1 << (cnt->number & 0x1f);
+ uint64_t event_mask = 1ULL << (cnt->number & 0x1f);
if (cnt->number & 0x20) {
cpu->pmceid1 |= event_mask;
} else {
--
2.20.1
- [Qemu-devel] [PULL 00/21] target-arm queue, Peter Maydell, 2019/02/21
- [Qemu-devel] [PULL 02/21] target/arm: v8M MPU should use background region as default, not always, Peter Maydell, 2019/02/21
- [Qemu-devel] [PULL 01/21] hw/arm/armsse: Fix memory leak in error-exit path, Peter Maydell, 2019/02/21
- [Qemu-devel] [PULL 04/21] target/arm: Restructure disas_fp_int_conv, Peter Maydell, 2019/02/21
- [Qemu-devel] [PULL 10/21] hw/timer/pl031: Convert to using trace events, Peter Maydell, 2019/02/21
- [Qemu-devel] [PULL 03/21] target/arm: Stop unintentional sign extension in pmu_init,
Peter Maydell <=
- [Qemu-devel] [PULL 13/21] hw/char/pl011: Use '0x' prefix when logging hex numbers, Peter Maydell, 2019/02/21
- [Qemu-devel] [PULL 09/21] hw/timer/pl031: Allow use as an embedded-struct device, Peter Maydell, 2019/02/21
- [Qemu-devel] [PULL 11/21] hw/char/pl011: Allow use as an embedded-struct device, Peter Maydell, 2019/02/21
- [Qemu-devel] [PULL 14/21] hw/arm/armsse: Document SRAM_ADDR_WIDTH property in header comment, Peter Maydell, 2019/02/21
- [Qemu-devel] [PULL 12/21] hw/char/pl011: Support all interrupt lines, Peter Maydell, 2019/02/21
- [Qemu-devel] [PULL 07/21] target/arm: Implement ARMv8.3-JSConv, Peter Maydell, 2019/02/21
- [Qemu-devel] [PULL 06/21] target/arm: Rearrange Floating-point data-processing (2 regs), Peter Maydell, 2019/02/21
- [Qemu-devel] [PULL 20/21] hw/arm/musca: Wire up PL011 UARTs, Peter Maydell, 2019/02/21
- [Qemu-devel] [PULL 16/21] hw/arm/musca.c: Implement models of the Musca-A and -B1 boards, Peter Maydell, 2019/02/21
- [Qemu-devel] [PULL 17/21] hw/arm/musca: Add PPCs, Peter Maydell, 2019/02/21