[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [Qemu-devel] [PATCH 09/18] softfloat: Fix Handling of Sma
From: |
Tom Musta |
Subject: |
Re: [Qemu-ppc] [Qemu-devel] [PATCH 09/18] softfloat: Fix Handling of Small Negatives in float64_to_uint64 |
Date: |
Mon, 16 Dec 2013 09:20:27 -0600 |
User-agent: |
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 |
On 12/12/2013 6:13 PM, Peter Maydell wrote:
> On 9 December 2013 15:47, Tom Musta <address@hidden> wrote:
>> The float64_to_uint64 routine exits early for all negative numbers.
>> While the integer result is always correctly returned as 0, the
>> exception flags are also always set to float_flag_invalid. This
>> is incorrect for those cases where a small negative number (-1 < x < 0)
>> rounds to zero. In such a case, the flag should be reported as
>> inexact.
>
>> -static int64 roundAndPackUint64(uint64_t absZ0, uint64_t absZ1 STATUS_PARAM)
>> +static int64 roundAndPackUint64(flag zSign, uint64_t absZ0,
>> + uint64_t absZ1 STATUS_PARAM)
>
> This function isn't in the copy of fpu/softfloat.c that's in master,
> unless I'm confused. Does this series depend on something else?
>
> thanks
> -- PMM
>
Peter: Yes, it does. See
http://lists.nongnu.org/archive/html/qemu-devel/2013-11/msg00045.html and
specifically patch 1/19.
[Qemu-ppc] [PATCH 08/18] target-ppc: Add ISA2.06 Float to Integer Instructions, Tom Musta, 2013/12/09
[Qemu-ppc] [PATCH 10/18] softfloat: Fix float64_to_uint64_round_to_zero, Tom Musta, 2013/12/09
[Qemu-ppc] [PATCH 11/18] softfloat: Fix float64_to_uint32, Tom Musta, 2013/12/09
[Qemu-ppc] [PATCH 12/18] softfloat: Fix float64_to_uint32_round_to_zero, Tom Musta, 2013/12/09
[Qemu-ppc] [PATCH 13/18] target-ppc: Add ISA 2.06 fcfid[u][s] Instructions, Tom Musta, 2013/12/09
[Qemu-ppc] [PATCH 14/18] target-ppc: Fix and enable fri[mnpz], Tom Musta, 2013/12/09
[Qemu-ppc] [PATCH 15/18] target-ppc: Add ISA 2.06 ftdiv Instruction, Tom Musta, 2013/12/09
[Qemu-ppc] [PATCH 16/18] target-ppc: Add ISA 2.06 ftsqrt, Tom Musta, 2013/12/09