[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [Qemu-devel] [V4 PATCH 05/22] softfloat: Fix float64_to_u
From: |
Peter Maydell |
Subject: |
Re: [Qemu-ppc] [Qemu-devel] [V4 PATCH 05/22] softfloat: Fix float64_to_uint32_round_to_zero |
Date: |
Thu, 19 Dec 2013 21:41:41 +0000 |
On 18 December 2013 20:19, Tom Musta <address@hidden> wrote:
> The float64_to_uint32_round_to_zero routine is incorrect.
>
> For example, the following test pattern:
>
> 425F81378DC0CD1F / 0x1.f81378dc0cd1fp+38
>
> will erroneously set the inexact flag.
>
> This patch re-implements the routine to use the
> float64_to_uint64_round_to_zero
> routine. If saturation occurs and the inexact flag was not previously set, it
> will be cleared.
Code is OK but you forgot to update this commit message.
>
> This contribution can be licensed under either the softfloat-2a or -2b
> license.
>
> V4: Correct commit commentary. Corrected code to properly handle the
> stickiness of the inexact flag.
These 'changes from previous version' comments should ideally go
below the "---" line, by the way. The idea is that the bit above the
line goes into the git commit history and should be a self-contained
description of the final patch.
> Signed-off-by: Tom Musta <address@hidden>
If you fix the commit message you can add:
Reviewed-by: Peter Maydell <address@hidden>
thanks
-- PMM
- [Qemu-ppc] [V4 PATCH 00/22] PowerPC VSX Stage 3, Tom Musta, 2013/12/18
- [Qemu-ppc] [V4 PATCH 01/22] softfloat: Fix float64_to_uint64, Tom Musta, 2013/12/18
- [Qemu-ppc] [V4 PATCH 02/22] softfloat: Add float32_to_uint64(), Tom Musta, 2013/12/18
- [Qemu-ppc] [V4 PATCH 03/22] softfloat: Fix float64_to_uint64_round_to_zero, Tom Musta, 2013/12/18
- [Qemu-ppc] [V4 PATCH 04/22] softfloat: Fix float64_to_uint32, Tom Musta, 2013/12/18
- [Qemu-ppc] [V4 PATCH 05/22] softfloat: Fix float64_to_uint32_round_to_zero, Tom Musta, 2013/12/18
- Re: [Qemu-ppc] [Qemu-devel] [V4 PATCH 05/22] softfloat: Fix float64_to_uint32_round_to_zero,
Peter Maydell <=
- [Qemu-ppc] [V4 PATCH 06/22] target-ppc: Add set_fprf Argument to fload_invalid_op_excp(), Tom Musta, 2013/12/18
- [Qemu-ppc] [V4 PATCH 07/22] target-ppc: General Support for VSX Helpers, Tom Musta, 2013/12/18
- [Qemu-ppc] [V4 PATCH 08/22] target-ppc: Add VSX ISA2.06 xadd/xsub Instructions, Tom Musta, 2013/12/18
- [Qemu-ppc] [V4 PATCH 10/22] target-ppc: Add VSX ISA2.06 xdiv Instructions, Tom Musta, 2013/12/18
- [Qemu-ppc] [V4 PATCH 09/22] target-ppc: Add VSX ISA2.06 xmul Instructions, Tom Musta, 2013/12/18
- [Qemu-ppc] [V4 PATCH 12/22] target-ppc: Add VSX ISA2.06 xsqrt Instructions, Tom Musta, 2013/12/18
- [Qemu-ppc] [V4 PATCH 11/22] target-ppc: Add VSX ISA2.06 xre Instructions, Tom Musta, 2013/12/18
- [Qemu-ppc] [V4 PATCH 16/22] target-ppc: Add VSX ISA2.06 Multiply Add Instructions, Tom Musta, 2013/12/18
- [Qemu-ppc] [V4 PATCH 13/22] target-ppc: Add VSX ISA2.06 xrsqrte Instructions, Tom Musta, 2013/12/18
- [Qemu-ppc] [V4 PATCH 14/22] target-ppc: Add VSX ISA2.06 xtdiv Instructions, Tom Musta, 2013/12/18