|
From: | Alexey Kardashevskiy |
Subject: | Re: [Qemu-ppc] [PATCH qemu] spapr: Add /system-id |
Date: | Thu, 26 Nov 2015 15:29:07 +1100 |
User-agent: | Mozilla/5.0 (X11; Linux i686 on x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 11/26/2015 11:49 AM, David Gibson wrote:
On Wed, Nov 25, 2015 at 04:15:01PM +0100, Alexander Graf wrote:On 18.11.15 11:49, David Gibson wrote:On Wed, Nov 18, 2015 at 06:45:39PM +1100, Alexey Kardashevskiy wrote:On 11/09/2015 07:47 PM, David Gibson wrote:On Mon, Nov 09, 2015 at 05:47:17PM +1100, Alexey Kardashevskiy wrote:Section B.6.2.1 Root Node Properties of PAPR specification defines a set of properties which shall be present in the device tree root, one of these properties is "system-id" which "should be unique across all systems and all manufacturers". Since UUID is meant to be unique, it makes sense to use it as "system-id". This adds "system-id" property to the device tree root when not empty. Signed-off-by: Alexey Kardashevskiy <address@hidden> --- This might be expected by AIX so here is the patch. I am really not sure if it makes sense to initialize property when UUID is all zeroes as the requirement is "unique" and zero-uuid is not.Yeah, I think it would be better to omit system-id entirely when a UUID hasn't been supplied.so this did not go anywhere yet, did it?No.So where is it stuck?I was waiting for a respin which didn't set the property when a UUID hadn't been given.
This is the original patch: + if (qemu_uuid_set) { + _FDT((fdt_property_string(fdt, "system-id", buf))); + } I does not set property if qemu_uuid_set==false already. What did I miss? -- Alexey
[Prev in Thread] | Current Thread | [Next in Thread] |