Re: [Quilt-dev] [PATCH] -h output, export command and more.

[Andreas Gruenbacher]

Hello,

sorry it took me ages to look over your changes. Many thanks for your
your patches. I have integrated #1, and modified #2 so that setting
QUILT_SERIES (in .quiltrc or in the environment) leads to the intended
effect.

As far as the export command is concerned, I don't see why having a
command that that puts patches in the right order by adding number
prefixes is a significant advantage, so maybe you can explain. I know
that people used to produce patch sets like that, but I nevertheless
think it's not a good idea. It helps when saving a number of patches
from emails to the file system, but it's also not hard at all to create
the correct series file. One difference is when applying patches, but
that IMHO isn't significant, either. With numbered files, instead of:

   for p in $(cat series); do ...; done

one needs somethign like:

   LANG=C for p in *; do ...; done

For people who further work on the patch set and insert patches etc.
it's inconvenient. Finally you end up with things like 01_patch 02_patch
99_patch 003_patch 999_patch. Figuring out the actual sort order alone
is a nuisance.

Of course the series file can contain comments, and can mix patches with
different strip levels. But it's easy to throw away comments, and if
different strip levels are used, then export would fail as well (and I
think that's fine).

On Sun, 2004-01-11 at 19:17, Manuel Estrada Sainz wrote:
>  Hi,
> 
>  First of all: thanks for a great tool, quilt rocks!!!
> 
>  There are some issues that I have been trying to overcome, attached goes some
>  patches. Each patch starts with a changelog.
> 
>  The patches are not finished, although they do work, please comment on them.
> 
>  Specially I would like to discuss:
> 
>  - export:
>       - layout and format of export directory.
>       - 'import' could also be extended to handle the result.
> 
>  - I would like to add an email-batch-patch-sending command compatible at 
> least
>    with linux-kernel mailing list practices.
> 
>       - My inspiration is Greg's
>         http://kernelnewbies.org/scripts/send_lots_of_email.pl

Maybe extracting a meaningful subject line from the patch makes sense?

>       - I am more fluent in python than perl but I guess that since
>         scripts/parse-patch already requires perl I should do any helper
>         script in perl, is that it?

I would indeed prefer that, to keep down the number of tools involved.

>       - To make it harder to flood with broken stuff, I would make it work
>         based on the output of 'export' command instead of directly from the
>         patch series. That should encourage checking that everything is OK
>         before sending.

Well, it makes it slightly harder to foul it up, but it also makes it
harder to get the job done.

>  - I also miss patch renaming. Would a patch to add a 'rename' command be
>    welcomed?

Yes.


Cheers,
-- 
Andreas Gruenbacher <address@hidden>
SUSE Labs, SUSE LINUX AG