savannah-hackers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Savannah-help-public] [sr #107662] 'Job Title' absent


From: Ryan Doyle
Subject: [Savannah-help-public] [sr #107662] 'Job Title' absent
Date: Mon, 26 Dec 2011 06:50:16 +0000
User-agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/535.7 (KHTML, like Gecko) Chrome/16.0.912.63 Safari/535.7

Update of sr #107662 (project administration):

             Assigned to:                    None => rdoyle                 

    _______________________________________________________

Follow-up Comment #1:

I agree that this information would be good to have on the details of the job
being viewed.

See the attached screenshot, I think this is cleared. The job title is the
main heading as well as the project. Additionally, the category is also listed
where date, submitter etc.. is located.

Diff required for the changes below:

========
address@hidden:/var/www/savane/frontend/php/people# git diff viewjob.php 
diff --git a/frontend/php/people/viewjob.php
b/frontend/php/people/viewjob.php
index a72c5cc..181887f 100644
--- a/frontend/php/people/viewjob.php
+++ b/frontend/php/people/viewjob.php
@@ -39,7 +39,8 @@ if ($group_id && $job_id)
 
   #for security, include group_id
   $result=db_execute("SELECT
groups.group_name,groups.type,groups.unix_group_name,people_job_category.name
AS category_name,".
-     "people_job_status.name AS status_name,people_job.title,".
+     "people_job_status.name AS status_name,people_job.title AS job_title,".
+     "people_job.category_id AS category_id,".
      "people_job.description,people_job.date,user.user_name,user.user_id ".
      "FROM people_job,groups,people_job_status,people_job_category,user ".
      "WHERE people_job_category.category_id=people_job.category_id ".
@@ -59,10 +60,11 @@ if ($group_id && $job_id)
       $project=project_get_object($group_id);
       print '
                <h2 class=toptitle>';
-      print db_result($result,0,'category_name');
+      print db_result($result,0,'job_title');
 
-      print  ' '._("wanted for").' <a
href="'.$GLOBALS['sys_home'].'projects/'. 
db_result($result,0,'unix_group_name') .'">'.
db_result($result,0,'group_name') .'</a></h2>'.
-       '<p><span class="preinput">'._("Submitted By:").'</span> <a
href="'.$GLOBALS['sys_home'].'users/'. db_result($result,0,'user_name') .'">'.
db_result($result,0,'user_name').'</a><br />'.
+      print  ' '._("for").' <a href="'.$GLOBALS['sys_home'].'projects/'. 
db_result($result,0,'unix_group_name') .'">'.
db_result($result,0,'group_name') .'</a></h2>'.
+       '<p><span class="preinput">'._("Category:").'</span> <a href="' .
$GLOBALS['sys_home'] . 'people/?category_id=' .
db_result($result,0,'category_id') .
'">'.db_result($result,0,'category_name').'</a><br />'.
+       '<span class="preinput">'._("Submitted By:").'</span> <a
href="'.$GLOBALS['sys_home'].'users/'. db_result($result,0,'user_name') .'">'.
db_result($result,0,'user_name').'</a><br />'.
        '<span class="preinput">'._("Date:").'</span> '.
utils_format_date(db_result($result,0,'date')) .'<br />'.
        '<span class="preinput">'._("Status:").'</span> '.
db_result($result,0,'status_name').'</p>';

========

I will update the Savane codebase with these changes if no one else objects
and push to savannah.gnu.org.

(file #24669)
    _______________________________________________________

Additional Item Attachment:

File name: screenshot_viewjpb_changes.png Size:100 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/support/?107662>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]