simulavr-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Simulavr-devel] [PATCH] Reduce warnings about registers not simulat


From: ThomasK
Subject: Re: [Simulavr-devel] [PATCH] Reduce warnings about registers not simulated
Date: Thu, 23 Feb 2012 19:21:08 +0100
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.24) Gecko/20111108 Lightning/1.0b2 Thunderbird/3.1.16

Hi Torsten,

thanks for your informations about opensuse package. A I can see, that you've produced packages for 11.4 and 12.1. Is this then also included in opensuse distribution, e.g. it's installable by yast or yum or such? I think, I'll add a comment in documentation. And, as I've seen, this is only simulavr itself, not python or tcl interface, right?

I made 2 patches, the first of which I'd like you to consider for
upstream inclusion. Please comment or apply.

2 patches? You mean this patch on 2 files in your message or do I've overseen the other patch? :-)

NotSimulatedRegister warns on stdout about each r/w access to each
instance. This causes not only the regular startup messages to scroll
off screen, but also warnings about config registers used only once
during device initialisation. This patch makes simulavr warn only once
for every register written, and for the 10 first registers'
read-before-write accesses.

Good Idea. And you're right, because of some peripherals are not implemented or if somebody tries to use a register, which isn't available, but it would not influece the control flow, if used, it would produce a lot of warning messages again and again. So it looks as a good idea to limit this messages. (it's not only NotSimulatedRegister class, also InvalidMem class by example)

On the other hand, maybe later in simulation, where it's necessary to get a hint, why code isn't running as expected, it would not bring this message. So it's a classic conflict, to much is bad, but to less also.

I'm not sure, if a command line option could help to switch the behaviour between all messages or only the first/first 10. Any ideas?

cu, Thomas



reply via email to

[Prev in Thread] Current Thread [Next in Thread]