Re: [Simulavr-devel] simulation with serialrx/tx is broken

[Marek Pietrzak]

Hi!

On 04/22/2012 12:35 PM, Klaus Rudolph wrote:
> Hi,
>
> I tried to simulate a serial connection with tcl gui and SerialRx and
> SerialTx. But the simulation did not work anymore, because the timing of
> SerialTx/Rx depends on correct behavior of the SystemClock->Step timer
> lists.
>
> There is a new implementation of step ordering which seems to be broken.
> Inserting a new step with a new offset in the list did not work anymore
> with serial devices. After inserting a new step with offset the step is
> done directly after the the step before and is not waiting for the given
> time in nextStepIn_ns.
>
> I did not understand the new RemoveMinimumAndInsert method, sorry.
>
> Can anyone help?
>
> Thanks
>   Klaus
>
>
>
>
> _______________________________________________
> Simulavr-devel mailing list
> address@hidden
> https://lists.nongnu.org/mailman/listinfo/simulavr-devel
The same here, recently I returned to my Python simulation playground 
and discovered it no longer works with latest version. I analysed diffs 
and discovered Petr had introduced min heap for step ordering which is a 
good move forward, yet his implementation appears to be broken. I 
suggest not to reinvent wheel and use STL algorithm suite (make_heap, 
etc.), unless there some assumptions I'm not aware of. I can provide a 
patch with STL's version of heap if anyone is interested.

Regards, Marek SQ3HTX