Re: [Tinycc-devel] can't build mob branch on x86 64

[Thomas Preud'homme]

Le samedi 05 février 2011 02:40:51, Thomas Preud'homme a écrit :
> Le samedi 05 février 2011 02:21:42, Joe Soroka a écrit :
> > On Fri, Feb 4, 2011 at 3:49 PM, Thomas Preud'homme <address@hidden>
> 
> wrote:
> > > Really? You want to rewrite it entirely? Took me so much time and it
> > > work well now :( Couldn't just some CONFIG_TCC_ALLOCA macro be defined
> > > in Makefile when compiling?
> > 
> > Rewrite it entirely, no.  I apologize for accidentally implying that.
> > While there *are* problems with your patch (doesn't handle size==0,
> > doesn't work with bcheck, some others) I don't mean to throw it out.
> 
> Well, for bcheck I just found it could come in a separate commit as it's
> still an improvement over no VLA at all. About the size, the test should
> even be about size < 0 I guess.
> 
> > I guess I just mean that the fact you missed the "TOK_alloca is an
> > enum" bit plus a few other simple things makes me worry about how well
> > tested the *complicated* stuff is and I'd kinda like to see you pull
> > it back, sleep on it, think on it, polish it a little bit and then
> > bring it back.  I went through the same kind of thing with my patch
> > for weak symbols - I had to throw it out and start over and ended up
> > with a much smaller, much better version.

By the way, I reverted the changes but I don't know when I will not have much 
time to work on VLA in the next weeks.

[SNIP]

Best regards,

Thomas Preud'homme

signature.asc
Description: This is a digitally signed message part.