[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: tramp-adb.el (Access Android devices filesystem using Emacs)

From: Michael Albinus
Subject: Re: tramp-adb.el (Access Android devices filesystem using Emacs)
Date: Wed, 25 May 2011 17:41:05 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux)

Jürgen Hötzel <address@hidden> writes:

> Hi Michael,

Hi Juergen,

> Just the docstring/value of tramp-adb-ls-errors were shuffled:

The usual just-one-line-change-before-i-send-i-cannot-do-it-wrong ...

Enclosed the next patch set. Patch 0002 and 0003 were needed, because
I've tested today on a Windows XP machine, running Android SDK. There
seem to be still more oddities when being there, let's see next days.

Another question: why do you add this:

(add-to-list 'tramp-default-method-alist
             (list "\\`adb" nil tramp-adb-method))

It means: If somebody does not use an explicit method, but the host name
starts with "adb", the method "adb" shall be used.

I doubt, that there are devices with such a name, but who knows ... I'm
still not very familar with the Android world. But I feel we could
remove this setting.

Furthermore, some TODOs might be cleaned up in for
tramp-adb-handle-insert-directory, I do not want to mess with this file.
And it seems to be possible to read on non-rooted devices at least, I've
tested it on my (non-rooted) Nexus S.

> Jürgen

Best regards, Michael.

Attachment: 0001-Use-tramp-adb-program-for-executable-name.patch
Description: Text Data

Attachment: 0002-Remove-trailing-M-on-W32-machines.patch
Description: Text Data

Attachment: 0003-Add-tramp-adb-handle-file-truename.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]