Re: Enable adb port in tramp adb

From:

Ashi

Subject:

Date:

Mon, 17 Nov 2014 21:30:51 +0800

Hi, Michael,
This update includes following change:
- Fix the auto completion bug.

On Thu, Nov 13, 2014 at 7:40 PM, Michael Albinus <address@hidden> wrote:

Ashi <address@hidden> writes:

> Hi, Michael,

Hi Zhongwei,

Thanks for the revised patch. It is fine so far, except that
tramp-default-adb-port might be tramp-default-port in the "adb" entry of
tramp-methods. There won't be a name clash, and we would avoid to touch
the docstring of tramp-methods :-) Its value might be the number 5555,
instead of the string "5555" - that's what we mean.

But if we set the tramp-default-port as 5555, (tramp-file-name-port vec) would always 5555 even it is under USB mode, which is not correct.
What about a name: tramp-default-adb-tcp-port ?

> adb:[android-c05807abea645fdf.fritz.box:5555]:
>
> Hmm, the last entry isn't like it should be.
>
> Yes, it is a bug. I haven't fixed it yet in this update. I'll update
> the patch again when I solve this.

Well, let's wait for this. We need to wait anyway, until the FSF has
confirmed your legal status. I cannot commit your patch before.

> Best regards,
> Zhongwei

Best regards, Michael.

Best regards,
Zhongwei