Re: [Wesnoth-dev] KISS Solution to user campaign stability problems

[David White]

ott wrote:

> On Thu, Jun 23, 2005 at 06:25:55PM -0500, David White wrote:
>  
>
> > I've committed a fix by making 
> > preprocess_file() once again modify the map that's passed in with the 
> > new defines. This means that user campaigns will inherit the defines map 
> > from the parse of game.cfg as they should.
> >    
>
> Further investigation shows some odd behaviour.  With every campaign
> server download present, I successively tried to run each campaign that
> was selectable in the Campaign menu (ie. all downloads that are not just
> content packs, and that pass the basic syntax check).  I summarised the
> current state of all campaigns in the thread, the same place as before:
>    http://www.wesnoth.org/forum/viewtopic.php?t=6463
>  
I made an additional change to game.cpp when I realized there was a 
problem. Did you get this change in the version you compiled?

> This seems to support silene's statement on IRC that
> config corruption is occurring.
>  
I'm afraid I can't see where the corruption he speaks of is occurring. 
He said that the problem is the default_defines_ map is re-used every 
time, and never cleared, but default_defines_ is a member of 
preprocessor_streambuf, and as far as I can see, a new 
preprocessor_streambuf instance is created every time a pre-processor 
parse is done.

Silene, can you please clarify what the problem is?

David