Re: [Adonthell-devel] v0.4 event system

[Alexandre Courbot]

Kai Sterker wrote:
> I've just committed the first code for the 0.4 event system. It's not 
> finished yet, but at least it should compile. Couldn't test under Linux 
> yet, though.

Hehe. Guess what! ;)

g++ -DHAVE_CONFIG_H -I. -I../.. -I../../libltdl 
-DPKGLIBDIR=\"/usr/local/lib/adonthell\" -g -Wall -fno-exceptions 
-fno-rtti -I../../src/ -MT libadonthell_base_la-diskio.lo -MD -MP -MF 
.deps/libadonthell_base_la-diskio.Tpo -c diskio.cc  -fPIC -DPIC -o 
.libs/libadonthell_base_la-diskio.lo
In file included from /usr/include/stdlib.h:43,
                 from /usr/include/c++/3.3.2/cstdlib:52,
                 from /usr/include/c++/3.3.2/bits/stl_algobase.h:67,
                 from /usr/include/c++/3.3.2/memory:54,
                 from /usr/include/c++/3.3.2/string:48,
                 from ../../src/base/flat.h:32,
                 from ../../src/base/diskio.h:32,
                 from diskio.cc:29:
/usr/include/bits/waitstatus.h:78: error: declaration of `unsigned int 
wait::<anonymous struct>::__w_retcode'
/usr/include/bits/waitstatus.h:73: error: conflicts with previous 
declaration `unsigned int wait::<anonymous struct>::__w_retcode'
/usr/include/bits/waitstatus.h:79: error: declaration of `unsigned int 
wait::<anonymous struct>::__w_coredump'
/usr/include/bits/waitstatus.h:72: error: conflicts with previous 
declaration `unsigned int wait::<anonymous struct>::__w_coredump'
/usr/include/bits/waitstatus.h:80: error: declaration of `unsigned int 
wait::<anonymous struct>::__w_termsig'
/usr/include/bits/waitstatus.h:71: error: conflicts with previous 
declaration `unsigned int wait::<anonymous struct>::__w_termsig'
/usr/include/bits/waitstatus.h:92: error: declaration of `unsigned int 
wait::<anonymous struct>::__w_stopsig'
/usr/include/bits/waitstatus.h:87: error: conflicts with previous 
declaration `unsigned int wait::<anonymous struct>::__w_stopsig'
/usr/include/bits/waitstatus.h:93: error: declaration of `unsigned int 
wait::<anonymous struct>::__w_stopval'
/usr/include/bits/waitstatus.h:86: error: conflicts with previous 
declaration `unsigned int wait::<anonymous struct>::__w_stopval'
In file included from ../../src/base/diskio.h:32,
                 from diskio.cc:29:
../../src/base/flat.h: In member function `void 
base::flat::put_uint16(const std::string&, const short unsigned int&)':
../../src/base/flat.h:136: error: `Swap16' undeclared (first use this 
function)
../../src/base/flat.h:136: error: (Each undeclared identifier is 
reported only once for each function it appears in.)
../../src/base/flat.h: In member function `void 
base::flat::put_sint16(const std::string&, const short int&)':
../../src/base/flat.h:140: error: `Swap16' undeclared (first use this 
function)
../../src/base/flat.h: In member function `void 
base::flat::put_uint32(const std::string&, const unsigned int&)':
../../src/base/flat.h:144: error: `Swap32' undeclared (first use this 
function)
../../src/base/flat.h: In member function `void 
base::flat::put_sint32(const std::string&, const int&)':
../../src/base/flat.h:148: error: `Swap32' undeclared (first use this 
function)
../../src/base/flat.h: In member function `short unsigned int 
base::flat::get_uint16(const std::string&)':
../../src/base/flat.h:208: error: `Swap16' undeclared (first use this 
function)
../../src/base/flat.h: In member function `short int 
base::flat::get_sint16(const std::string&)':
../../src/base/flat.h:214: error: `Swap16' undeclared (first use this 
function)
../../src/base/flat.h: In member function `unsigned int 
base::flat::get_uint32(const std::string&)':
../../src/base/flat.h:220: error: `Swap32' undeclared (first use this 
function)
../../src/base/flat.h: In member function `int 
base::flat::get_sint32(const std::string&)':
../../src/base/flat.h:227: error: `Swap32' undeclared (first use this 
function)
make[3]: *** [libadonthell_base_la-diskio.lo] Erreur 1
make[3]: Leaving directory `/home/alex/Work/Adonthell/adonthell/src/base'
make[2]: *** [all-recursive] Erreur 1
make[2]: Leaving directory `/home/alex/Work/Adonthell/adonthell/src'
make[1]: *** [all-recursive] Erreur 1
make[1]: Leaving directory `/home/alex/Work/Adonthell/adonthell'
make: *** [all] Erreur 2


I don't know what's going on for the first throw of errors. The files 
seems to be included correctly. And I have plenty of classes (like 
gfx/screen.cc) which seems to have the *exact* same beginning with the 
same include orders! I tried with a compilation line that worked with 
screen.cc, but it still fails. Any idea?

The second throw of errors seems to happen on little-endian machines. 
Looks like the macros in base/endian.h are not declared in these cases.

Apart from these problems, the code looks very clean. Neat! :) That's 
great work Kai, I hope to commit again soon myself.

Alex.
--
http://www.gnurou.org