Re: non portable sed scripts

[Ralf Wildenhues]

[ Cc:ing autoconf-patches ]

Hi Tim,

* Tim Rice wrote on Wed, May 24, 2006 at 01:43:14AM CEST:
> On Tue, 23 May 2006, Ralf Wildenhues wrote:
> > * Tim Rice wrote on Sun, May 21, 2006 at 11:37:53PM CEST:
> > > Just for another data point I built an tested autoconf-2.59c on
> > > my 7.1.4 box (where I have up to date GNU m4 and perl) and got some
> > > errors. "testsuite: 65 failed, 48 passed unexpectedly"
> > 
> > Please run
> >   env TESTSUITEFLAGS='-v -d -x 48' make -e check

> Here is the testsuite.log from test 048
*snip*

> 1. mysuite.at:3: testing ...
> /mysuite.at:8: echo 'foo
> bar'
> + echo $'foo\nbar'
> 1. mysuite.at:3:  ok

> 1 test was successful.
> 48. autotest.at:169: 48. Multiline command from M4 expansion 
> (autotest.at:169): UNEXPECTED PASS       (sys    0m0.34s)

Ahh, thanks.  We forgot to take ksh style quoting into account.
I'm checking this in.

Cheers, and thanks!
Ralf

        * tests/autotest.at (Multiline command from M4 expansion):
        No failure to be expected if the shell quotes newlines in
        commands in the `set -x' output.  Report by Tim Rice.
        * THANKS: Update.

Index: THANKS
===================================================================
RCS file: /cvsroot/autoconf/autoconf/THANKS,v
retrieving revision 1.133
diff -u -r1.133 THANKS
--- THANKS      11 Apr 2006 17:34:03 -0000      1.133
+++ THANKS      24 May 2006 03:42:28 -0000
@@ -208,6 +208,7 @@
 Thien-Thi Nguyen            address@hidden
 Thomas Winder               address@hidden
 Tim Van Holder              address@hidden
+Tim Rice                    address@hidden
 Tom Lane                    address@hidden
 Tom Purcell                 address@hidden
 Tom Tromey                  address@hidden
Index: tests/autotest.at
===================================================================
RCS file: /cvsroot/autoconf/autoconf/tests/autotest.at,v
retrieving revision 1.16
diff -u -r1.16 autotest.at
--- tests/autotest.at   12 Apr 2006 18:55:49 -0000      1.16
+++ tests/autotest.at   24 May 2006 03:41:11 -0000
@@ -160,13 +160,14 @@
 ## ---------------------------- ##
 
 # The last paragaph in the comment above _AT_DECIDE_TRACEABLE illustrates why
-# this test fails.
+# this test fails (except with Korn shell-style quoting $'foo\nbar').
 AT_CHECK_AT_TEST([Multiline command from M4 expansion],
   [m4_define([GNU], ['foo
 bar'])
    AT_CHECK([echo GNU], 0, [foo
 bar
-], [])], [:])
+], [])], [case `( set -x; echo 'foo
+bar') 2>&1` in *\$\'foo\\nbar\'*) false;; *) :;; esac])
 
 AT_CHECK_AT_TEST([Double-M4-quoted command],
   [m4_define([GNU], ['foo