[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: testsuite -C dir

From: Ralf Wildenhues
Subject: Re: testsuite -C dir
Date: Mon, 28 Jan 2008 21:37:40 +0100
User-agent: Mutt/1.5.13 (2006-08-11)

Hi Eric,

* Eric Blake wrote on Mon, Jan 28, 2008 at 03:07:14PM CET:
> Applied, after one more round of testing with m4 (there were some
> additional impacts, like having to use $at_myself rather than $0 to
> reinvoke the --list option of the testsuite to name failed tests in the
> log).  Also, in the process, I noticed that a standalone test (one where
> atconfig is not present), the platform information was not captured in the
> log; also the PATH sanitization was taking a long time on cygwin prior to
> running the first test.  Fixed as follows:

> @@ -361,31 +361,6 @@ fi
>  ## ---------------------- ##
>  m4_divert_pop([PREPARE_TESTS])dnl back to DEFAULTS
> -# Load the config file.
> -for at_file in atconfig atlocal
> -do
> -  test -r $at_file || continue
> -  . ./$at_file || AS_ERROR([invalid content: $at_file])
> -done

Isn't this an API change?  It looks to me the at* files are now
interpreted after the command line (untested).  That seems wrong:
the command line should override atlocal, if I do
  ./testsuite PERL=/some/other/perl

Cheers, and thanks for working on this,

reply via email to

[Prev in Thread] Current Thread [Next in Thread]