[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: patch to add AT_CHECK_EUNIT autotest macro

From: Romain Lenglet
Subject: Re: patch to add AT_CHECK_EUNIT autotest macro
Date: Fri, 31 Jul 2009 22:24:04 +0900
User-agent: KMail/1.11.4 (Linux/2.6.30-1-686; KDE/4.2.4; i686; ; )

On Friday 31 July 2009 16:24:38 Romain Lenglet wrote:
> Paolo Bonzini wrote:
> >> The macro requires variables ERL, ERLC, and ERLCFLAGS to be defined. I
> >> documented that those should be configured by configure, and I modified
> >> the generated atconfig file to contain those configured values. It's
> >> simple and transparent, but may be ugly since those will be defined for
> >> all testsuites, even those that don't use AT_CHECK_EUNIT. Any suggestion
> >> to make it better? And should I exit with code 99, in AT_CHECK_EUNIT, if
> >> those variables are not defined?
> >
> > No, probably with code 77 (skip the testcase if EUnit is not installed).
> OK, I'll send an updated patch this weekend to do that.

Here is an updated version of my patch, with tests added into AT_CHECK_EUNIT 
to skip the test group if either ERL or ERLC is not a file path, or if the 
EUnit library cannot be found. I hand tested that the test is really skipped 
in those cases.
I updated the documentation too.

Romain Lenglet

Attachment: 0001-Add-AT_CHECK_EUNIT-macro-to-run-Erlang-EUnit-unittes.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]